ScriptManager caches the rejected promise when a resolver throws, so loadScript/prefetchScript never retry

Aberta
  • Algo errado?
#1,506 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

@linhh-phv já está trabalhando nisso.

Desde 20/10/2026.

  • #1507 de @linhh-phv — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Estagnada
Stack de tecnologia
react-native, typescript, webpack
Domínio
tooling

Direção de pesquisa

Read the loadScript and prefetchScript implementations in ScriptManager and the linked ScriptManager.test.ts reproduction. Check how each method handles a rejected resolveScript call and how its cached promise is cleaned up. Done when the resolver is called again on a retry after a resolver failure, and both reproduction tests pass.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Describe the bug

If a script resolver throws, ScriptManager keeps the rejected promise in scriptsPromises. Every later loadScript / prefetchScript call for the same script returns that same error and never calls the resolvers again. The only way out is to restart the app.

In loadScript and prefetchScript, resolveScript is awaited before the try / finally that removes the entry from scriptsPromises:

const loadProcess = async () => {
  let script = await this.resolveScript(/* ... */); // a throw here skips the finally below

  try {
    // ...
  } catch (error) {
    // ...
  } finally {
    // should delete script promise even script failed
    delete this.scriptsPromises[uniqueId];
  }
};

this.scriptsPromises[uniqueId] = loadProcess();

So the "delete even if it failed" path only runs for loading errors, not for resolving errors. The same pattern is in prefetchScript. It also affects loadScript after a failed prefetchScript, because loadScript awaits the cached prefetch promise and rethrows its error.

Expected: after a resolver error (e.g. the device was offline while the resolver fetched the script URL), the next loadScript call runs the resolvers again, the same way it already retries after a failed native load.

Actual: the next loadScript calls reject right away with the first error, even after the network is back. In our app a user who opened a mini app while offline could not open it again until they killed and reopened the app. A retry button on an error boundary or React.lazy remount did not help.

System Info
React Native 0.79.7 (New Architecture, Hermes)
@callstack/repack 5.2.5, bundler webpack 5, Module Federation v1
iOS and Android, release builds
Re.Pack Version

5.2.5. The code is unchanged in 5.4.2 and on main (32c32c0).

Reproduction

https://github.com/linhh-phv/repack/blob/fix/script-manager-retry-after-resolve-failure/packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts. The two tests should retry loadScript after resolver failure and should retry prefetchScript after resolver failure fail on main and pass with the fix.

Steps to reproduce

  1. Add a resolver that rejects once, then resolves:

    const resolver = jest
  .fn()
  .mockRejectedValueOnce(new Error('Network request failed'))
  .mockImplementation(async (scriptId) => ({ url: Script.getRemoteURL(scriptId) }));
ScriptManager.shared.addResolver(resolver);

  2. await ScriptManager.shared.loadScript('miniApp') rejects with Network request failed, as expected.

  3. Call await ScriptManager.shared.loadScript('miniApp') again: it rejects with the same error and resolver was called only once.

In an app: make the resolver depend on the network (for example, fetch the version or URL of a remote), open a federated remote while offline, turn the network back on, then try to open it again.

I have a fix ready and will open a PR: delete the cached promise when resolveScript throws, then rethrow.

Linguagem predominante
TypeScript
Estrelas
1.9k
Forks
177
Merge médio
2d 10h
PRs com merge (30d)
23

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de callstack/repack

Todas as issues de callstack/repack

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.