[bot] Google GenAI Batches API is not instrumented (mis-tagged as a generic LLM span)
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 38/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- java
调研方向
从 braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustApiClient.java 开始,尤其关注 tagSpan(),然后检查 BraintrustInstrumentation.java,以确认 client 和异步 batch 入口点。将 google-genai Batches API 的结构与现有 instrumentation 进行比较,并确定需要为 create、get、list、cancel 以及已完成结果添加的测试。完成的标准是 batch 操作具有适当的 span 数据和回归覆盖,同时不将 BatchJob metadata 视为生成输出。
由索引模型根据 Issue 内容生成。
描述
Summary
The genai_1_18_0 module instruments Google's google-genai Java SDK by subclassing its package-private ApiClient (com.google.genai.BraintrustApiClient) and swapping it into every service object on the Client, including client.batches and client.async.batches (BraintrustInstrumentation.wrapClient, lines 36–52). This means a call to client.batches.create(...)/.get(...)/.list(...)/.cancel(...)/.createEmbeddings(...) does produce a span — but BraintrustApiClient.tagSpan() has no awareness of the Batches API's request/response shape, so the span is mis-tagged: it's marked span_attributes.type = "llm" as if it were a real generation call, but the request/response field extraction (built for generateContent-shaped bodies) finds essentially nothing meaningful to populate.
What is missing
In braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustApiClient.java, tagSpan() (lines 50–161):
- Request metadata extraction (lines 65–76) looks for top-level
model,systemInstruction,tools,toolConfig,safetySettings,cachedContent. AbatchGenerateContentrequest body wraps everything under abatchobject ({"batch": {"displayName": ..., "inputConfig": {...}}}), and acreateEmbeddingsbatch job body is shaped aroundEmbeddingsBatchJobSource/CreateEmbeddingsBatchJobConfig— none of the expected top-level fields exist, so metadata stays essentially empty. input_jsonconstruction (lines 97–113) only populatesmodel/contents/config(fromgenerationConfig) — a batch-create body has none of these at top level (the model is only present in the URL path, e.g.{model}:batchGenerateContent, andgetModel(genAIEndpoint)(used as a fallback at line 102) is the only path by whichmodelwould end up ininput_jsonat all); the batch's actual per-itemcontents/generation requests (whether inline or file/GCS-referenced) are never captured.- Response handling (lines 116–150) dumps the whole response body as
output_json(line 125) — for a batch create/get call, that whole body is justBatchJobresource metadata (name,state,createTime, etc.), not generative output — and readsusageMetadatafor metrics (line 128), which aBatchJobresponse never has. There is no instrumentation at all of retrieving a completed batch's actual per-request results (where real generation outputs andusageMetadatabecome available), so even a fully successful batch job produces a span withtype: "llm"but no meaningful input, output, or token metrics. - No test or example anywhere in the repo exercises
client.batchesin any form (confirmed via grep forbatchunderbraintrust-sdk/instrumentation/genai_1_18_0/— the only match isBraintrustInstrumentation.java's own field-swap wiring, not a test).
Braintrust docs status: not_found
Checked https://www.braintrust.dev/docs/integrations/ai-providers/gemini in full: no mention of batchGenerateContent, Batches, or batch/async generation jobs anywhere, in any language. The only "batch"-adjacent mention is batchEmbedContents, and only in the unrelated context of AI proxy/gateway passthrough support for embeddings ("The gateway also supports Gemini's native embedContent and batchEmbedContents endpoints") — not span/tracing coverage, and not the Batches job API this issue is about.
Note: this repo's own gap-audit history already treats "Batch API not instrumented, mis-tagged as a generic LLM span" as a valid, in-scope finding — see the already-filed and still-open #155 for Anthropic's Message Batches API, which this issue mirrors for the Google GenAI provider (a distinct upstream API/SDK/module, not a duplicate).
Upstream sources
- Gemini API "Batch Mode" (
batchGenerateContent) — official docs: https://ai.google.dev/gemini-api/docs/batch-api and https://ai.google.dev/gemini-api/docs/batch-mode. Async, 50%-discounted, ~24h turnaround; supports inline requests or file/JSONL upload. - Vertex AI batch predictions for Gemini (and partner models) via GCS/BigQuery: https://docs.cloud.google.com/vertex-ai/generative-ai/docs/maas/capabilities/batch-prediction, with a Java-specific sample using the same
com.google.genai.Batchesclass: https://docs.cloud.google.com/vertex-ai/generative-ai/docs/samples/googlegenaisdk-batchpredict-with-gcs. - Official
google-genaiJava SDK exposes this directly:com.google.genai.Batches(googleapis/java-genai,src/main/java/com/google/genai/Batches.java), javadoc at https://googleapis.github.io/java-genai/javadoc/com/google/genai/Batches.html —create(String model, BatchJobSource, CreateBatchJobConfig),createEmbeddings(...)(experimental),get(...),cancel(...),delete(...),list(...), all returning/operating onBatchJob.
Local repo files inspected
braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustApiClient.java— lines 50–161 (tagSpan)braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustInstrumentation.java— lines 22–57 (wrapClient), confirmingclient.batches/client.async.batchesare explicitly wired to the same instrumentedApiClient(lines 37, 47) and therefore do produce (mis-tagged) spans rather than bypassing instrumentation entirely- Repo-wide grep for
batch/Batch/batchGenerateContent/BatchJobunderbraintrust-sdk/instrumentation/genai_1_18_0/— only match is the field-swap wiring above; no test or example exercises the Batches API
- 主要语言
- Java
- 星标
- 21
- 派生
- 5
- 平均合并
- 1 天 20 小时
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
braintrustdata/braintrust-sdk-java 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 68/100
查看 braintrustdata/braintrust-sdk-java 的全部 Issue
相似的 Issue
-
[BUG] 订单:会员凭订单号即可取消其他会员的待付款订单(取消接口不校验订单归属)可能已有人在做 @dadiyang 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
macrozheng/mall#1016 ·
-
[Bug] The producer summary counts an unreported client version as a second version and warns about a version mix可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 74/100
apache/rocketmq-dashboard#6110 ·
维护者通常 4 天内回复
-
Python 3.15 support可能已有人在做 @amnesiaof 今天认领。 未关闭L: python L: python:uv
难度 2/5 1-3 小时 新手友好度 72/100
dependabot/dependabot-core#16524 · 1 条评论 ·
维护者通常 1 天内回复
-
`Processing lsp` never exits and leaves orphaned processes可能已有人在做 @overcast302 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 72/100
processing/processing4#1578 · 1 条评论 ·
-
bug needs triage
难度 2/5 1-3 小时 新手友好度 72/100
PlayersCommittee/gemp-swccg-public#1174 ·
维护者通常 2 天内回复