[bot] Google GenAI Batches API is not instrumented (mis-tagged as a generic LLM span)
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 38/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Tranquilo
- Stack tecnológico
- java
- Área
- observability-sre
Línea de trabajo
Comienza con braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustApiClient.java, especialmente con tagSpan(), y después inspecciona BraintrustInstrumentation.java para confirmar el cliente y los puntos de entrada de los lotes asíncronos. Compara las estructuras de la google-genai Batches API con la instrumentación existente e identifica las pruebas que se deben añadir para create, get, list, cancel y los resultados completados. Se considera terminado cuando las operaciones de lotes tienen datos de span adecuados y cobertura de regresión, sin tratar los metadatos de BatchJob como salida de generación.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
The genai_1_18_0 module instruments Google's google-genai Java SDK by subclassing its package-private ApiClient (com.google.genai.BraintrustApiClient) and swapping it into every service object on the Client, including client.batches and client.async.batches (BraintrustInstrumentation.wrapClient, lines 36–52). This means a call to client.batches.create(...)/.get(...)/.list(...)/.cancel(...)/.createEmbeddings(...) does produce a span — but BraintrustApiClient.tagSpan() has no awareness of the Batches API's request/response shape, so the span is mis-tagged: it's marked span_attributes.type = "llm" as if it were a real generation call, but the request/response field extraction (built for generateContent-shaped bodies) finds essentially nothing meaningful to populate.
What is missing
In braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustApiClient.java, tagSpan() (lines 50–161):
- Request metadata extraction (lines 65–76) looks for top-level
model,systemInstruction,tools,toolConfig,safetySettings,cachedContent. AbatchGenerateContentrequest body wraps everything under abatchobject ({"batch": {"displayName": ..., "inputConfig": {...}}}), and acreateEmbeddingsbatch job body is shaped aroundEmbeddingsBatchJobSource/CreateEmbeddingsBatchJobConfig— none of the expected top-level fields exist, so metadata stays essentially empty. input_jsonconstruction (lines 97–113) only populatesmodel/contents/config(fromgenerationConfig) — a batch-create body has none of these at top level (the model is only present in the URL path, e.g.{model}:batchGenerateContent, andgetModel(genAIEndpoint)(used as a fallback at line 102) is the only path by whichmodelwould end up ininput_jsonat all); the batch's actual per-itemcontents/generation requests (whether inline or file/GCS-referenced) are never captured.- Response handling (lines 116–150) dumps the whole response body as
output_json(line 125) — for a batch create/get call, that whole body is justBatchJobresource metadata (name,state,createTime, etc.), not generative output — and readsusageMetadatafor metrics (line 128), which aBatchJobresponse never has. There is no instrumentation at all of retrieving a completed batch's actual per-request results (where real generation outputs andusageMetadatabecome available), so even a fully successful batch job produces a span withtype: "llm"but no meaningful input, output, or token metrics. - No test or example anywhere in the repo exercises
client.batchesin any form (confirmed via grep forbatchunderbraintrust-sdk/instrumentation/genai_1_18_0/— the only match isBraintrustInstrumentation.java's own field-swap wiring, not a test).
Braintrust docs status: not_found
Checked https://www.braintrust.dev/docs/integrations/ai-providers/gemini in full: no mention of batchGenerateContent, Batches, or batch/async generation jobs anywhere, in any language. The only "batch"-adjacent mention is batchEmbedContents, and only in the unrelated context of AI proxy/gateway passthrough support for embeddings ("The gateway also supports Gemini's native embedContent and batchEmbedContents endpoints") — not span/tracing coverage, and not the Batches job API this issue is about.
Note: this repo's own gap-audit history already treats "Batch API not instrumented, mis-tagged as a generic LLM span" as a valid, in-scope finding — see the already-filed and still-open #155 for Anthropic's Message Batches API, which this issue mirrors for the Google GenAI provider (a distinct upstream API/SDK/module, not a duplicate).
Upstream sources
- Gemini API "Batch Mode" (
batchGenerateContent) — official docs: https://ai.google.dev/gemini-api/docs/batch-api and https://ai.google.dev/gemini-api/docs/batch-mode. Async, 50%-discounted, ~24h turnaround; supports inline requests or file/JSONL upload. - Vertex AI batch predictions for Gemini (and partner models) via GCS/BigQuery: https://docs.cloud.google.com/vertex-ai/generative-ai/docs/maas/capabilities/batch-prediction, with a Java-specific sample using the same
com.google.genai.Batchesclass: https://docs.cloud.google.com/vertex-ai/generative-ai/docs/samples/googlegenaisdk-batchpredict-with-gcs. - Official
google-genaiJava SDK exposes this directly:com.google.genai.Batches(googleapis/java-genai,src/main/java/com/google/genai/Batches.java), javadoc at https://googleapis.github.io/java-genai/javadoc/com/google/genai/Batches.html —create(String model, BatchJobSource, CreateBatchJobConfig),createEmbeddings(...)(experimental),get(...),cancel(...),delete(...),list(...), all returning/operating onBatchJob.
Local repo files inspected
braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustApiClient.java— lines 50–161 (tagSpan)braintrust-sdk/instrumentation/genai_1_18_0/src/main/java/com/google/genai/BraintrustInstrumentation.java— lines 22–57 (wrapClient), confirmingclient.batches/client.async.batchesare explicitly wired to the same instrumentedApiClient(lines 37, 47) and therefore do produce (mis-tagged) spans rather than bypassing instrumentation entirely- Repo-wide grep for
batch/Batch/batchGenerateContent/BatchJobunderbraintrust-sdk/instrumentation/genai_1_18_0/— only match is the field-swap wiring above; no test or example exercises the Batches API
- Lenguaje dominante
- Java
- Estrellas
- 21
- Forks
- 5
- Merge medio
- 2 d 7 h
- PR fusionados (30 d)
- 8
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de braintrustdata/braintrust-sdk-java
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Todos los issues de braintrustdata/braintrust-sdk-java
Issues similares
-
executions.Query — startDate and timeRange filters are sent with inverted comparison operators Abiertoarea/plugin
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
kestra-io/plugin-kestra#190 ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Add canonical URLs and a sitemap Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
apache/rocketmq-dashboard#5064 ·