Migrate transaction building from `TxBuilder` to `Wallet::create_psbt`
维护者通常 3 天内回复
还没有人认领这个 Issue。
评估
调研方向
Read the five listed call sites in src/handlers/offline.rs, src/handlers/dns/mod.rs, and src/handlers/payjoin/mod.rs, then review the bdk_wallet 3.2.0 Wallet::create_psbt and replace_by_fee APIs. Run just pre-push to identify signing, deprecation, and feature-configuration failures; done means all transaction paths use the new APIs and the checks pass.
由索引模型根据 Issue 内容生成。
描述
The plan is to transition bdk_wallet to depreciate TxBuilder and use bdk_tx via Wallet::create_psbt (see https://github.com/bitcoindevkit/bdk_wallet/pull/516). So I'd suggest adding the check to bdk-tx and updating bdk-cli to enable the Wallet::create_psbt experimental feature and using it. But that all will need to be done in new PRs.
Originally posted by @notmandatory in https://github.com/bitcoindevkit/bdk-cli/issues/326#issuecomment-5799371337
This issue is about moving bdk-cli to Wallet::create_psbt from bdk_wallet 3.2.0. The tx size check discussed in the same thread is out of scope here.
bdk-cli is on bdk_wallet 3.1.0 and builds every transaction with TxBuilder. Wallet::create_psbt is available in 3.2.0, behind the bdk-tx feature and the --cfg bdk_wallet_unstable rustflag.
Call sites to migrate:
CreateTxCommandinsrc/handlers/offline.rsCreateSpTxCommandinsrc/handlers/offline.rsBumpFeeCommandinsrc/handlers/offline.rs, the only one usingbuild_fee_bumpCreateDnsTxCommandinsrc/handlers/dns/mod.rsPayjoinManager::send_payjoininsrc/handlers/payjoin/mod.rs
Notes:
Wallet::replace_by_feeis the counterpart forbump_fee.- The bump also hits deprecations outside tx building, which
-D warningsin CI turns into blockers:Wallet::sign,Wallet::get_signers,Wallet::policies,TxBuilder::policy_pathandLoadParams::extract_keys. - The bump alone already breaks
just pre-push: every test that signs a PSBT fails withSigner error: Missing non-witness UTXO, to be sorted out as part of this work.
- 主要语言
- Rust
- 星标
- 142
- 派生
- 99
- 平均合并
- 5 天 21 小时
- 30 天内合并 PR
- 4
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
bitcoindevkit/bdk-cli 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
bitcoindevkit/bdk-cli#332 · 2 条评论 ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
bitcoindevkit/bdk-cli#330 ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
bitcoindevkit/bdk-cli#318 ·
维护者通常 3 天内回复
-
bug
难度 4/5 3-5 天 新手友好度 50/100
bitcoindevkit/bdk-cli#340 · 1 条评论 ·
维护者通常 3 天内回复
-
Enforce Core-compatible OP_RETURN / datacarrier and standard tx-size limits in create_tx可能已有人在做 @tvpeter 于 3 天前认领。 未关闭enhancement
bitcoindevkit/bdk-cli#339 · 已指派 1 人 ·
维护者通常 3 天内回复
查看 bitcoindevkit/bdk-cli 的全部 Issue
相似的 Issue
-
type/bug
难度 2/5 1-3 小时 新手友好度 68/100
stackabletech/kafka-operator#1033 · 1 条评论 ·
维护者通常 1 天内回复
-
bug good first issue needs testing
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 90/100
farion1231/cc-switch#7744 · 1 条评论 ·
维护者通常 1 天内回复
-
datafusion
难度 2/5 1-3 小时 新手友好度 76/100
apache/iceberg-rust#3297 ·
维护者通常 1 天内回复