Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Migrate transaction building from `TxBuilder` to `Wallet::create_psbt`

Abierto
  • ¿Algo no está bien?
#338 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
cli

Línea de trabajo

Read the five listed call sites in src/handlers/offline.rs, src/handlers/dns/mod.rs, and src/handlers/payjoin/mod.rs, then review the bdk_wallet 3.2.0 Wallet::create_psbt and replace_by_fee APIs. Run just pre-push to identify signing, deprecation, and feature-configuration failures; done means all transaction paths use the new APIs and the checks pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The plan is to transition bdk_wallet to depreciate TxBuilder and use bdk_tx via Wallet::create_psbt (see https://github.com/bitcoindevkit/bdk_wallet/pull/516). So I'd suggest adding the check to bdk-tx and updating bdk-cli to enable the Wallet::create_psbt experimental feature and using it. But that all will need to be done in new PRs.

Originally posted by @notmandatory in https://github.com/bitcoindevkit/bdk-cli/issues/326#issuecomment-5799371337

This issue is about moving bdk-cli to Wallet::create_psbt from bdk_wallet 3.2.0. The tx size check discussed in the same thread is out of scope here.

bdk-cli is on bdk_wallet 3.1.0 and builds every transaction with TxBuilder. Wallet::create_psbt is available in 3.2.0, behind the bdk-tx feature and the --cfg bdk_wallet_unstable rustflag.

Call sites to migrate:

  • CreateTxCommand in src/handlers/offline.rs
  • CreateSpTxCommand in src/handlers/offline.rs
  • BumpFeeCommand in src/handlers/offline.rs, the only one using build_fee_bump
  • CreateDnsTxCommand in src/handlers/dns/mod.rs
  • PayjoinManager::send_payjoin in src/handlers/payjoin/mod.rs

Notes:

  • Wallet::replace_by_fee is the counterpart for bump_fee.
  • The bump also hits deprecations outside tx building, which -D warnings in CI turns into blockers: Wallet::sign, Wallet::get_signers, Wallet::policies, TxBuilder::policy_path and LoadParams::extract_keys.
  • The bump alone already breaks just pre-push: every test that signs a PSBT fails with Signer error: Missing non-witness UTXO, to be sorted out as part of this work.
Lenguaje dominante
Rust
Estrellas
142
Forks
99
Merge medio
4 d 1 h
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de bitcoindevkit/bdk-cli

Todos los issues de bitcoindevkit/bdk-cli

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.