py_console_script_binary and gazelle modules_mapping warn about implicit __init__.py even after explicit_init_py(default = True)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- python
- 领域
- build-system
调研方向
Start with the affected entry points: python/entry_points/py_console_script_binary.bzl and the py_console_script_gen_py target, then inspect the modules_mapping generator and merger targets in rules_python_gazelle_plugin. Run the Bazel reproduction with explicit_init_py(default = True) and --incompatible_default_to_explicit_init_py. Done means the three warnings disappear while the generated outputs remain byte-identical and the console script still runs.
由索引模型根据 Issue 内容生成。
描述
🐞 bug report
Affected Rule
The issue is caused by the rule: py_console_script_binary (its generator, @rules_python//python/private:py_console_script_gen_py) and the gazelle plugin's modules_mapping (@rules_python_gazelle_plugin//modules_mapping:generator and :merger).
Is this a regression?
No. These tools have always relied on implicit __init__.py creation; the deprecation warning is what's new.
Description
The module-wide explicit_init_py setting (#3997) only covers the declaring module's own targets. These three py_binary tools belong to rules_python and rules_python_gazelle_plugin, which don't declare it for themselves or set legacy_create_init on the targets. So any module that uses py_console_script_binary or modules_mapping still gets the warning after opting itself in, and has nothing left to change.
The tools don't seem to need the implicit files. With --incompatible_default_to_explicit_init_py, the repro below builds byte-identical outputs (the generated entry point and the modules-mapping JSON), and the console script still runs. So legacy_create_init = 0 on the three targets, or explicit_init_py(default = True) in both modules, looks sufficient.
The three targets are unchanged on main. py_console_script_gen_py was also mentioned in a comment on #2945.
🔬 Minimal Reproduction
MODULE.bazel:
bazel_dep(name = "rules_python", version = "2.3.4")
bazel_dep(name = "rules_python_gazelle_plugin", version = "2.3.4")
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
python.toolchain(python_version = "3.13")
pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
pip.parse(
hub_name = "pypi",
python_version = "3.13",
requirements_lock = "//:requirements.txt",
)
use_repo(pip, "pypi")
rules_python_config = use_extension("@rules_python//python/extensions:config.bzl", "config")
rules_python_config.explicit_init_py(default = True)
BUILD.bazel:
load("@pypi//:requirements.bzl", "all_whl_requirements")
load("@rules_python//python/entry_points:py_console_script_binary.bzl", "py_console_script_binary")
load("@rules_python_gazelle_plugin//modules_mapping:def.bzl", "modules_mapping")
py_console_script_binary(
name = "pyflakes",
pkg = "@pypi//pyflakes",
)
modules_mapping(
name = "modules_map",
wheels = all_whl_requirements,
)
requirements.txt:
pyflakes==3.4.0
bazel build --nobuild //...
🔥 Exception or Error
WARNING: Target @@rules_python_gazelle_plugin+//modules_mapping:generator is using implicit __init__.py creation.
WARNING: Target @@rules_python_gazelle_plugin+//modules_mapping:merger is using implicit __init__.py creation.
WARNING: Target @@rules_python+//python/private:py_console_script_gen_py is using implicit __init__.py creation.
🌍 Your Environment
Operating System:
macOS (arm64); the same three warnings on Linux x86_64 and aarch64
Output of bazel version:
Build label: 9.2.0
Rules_python version:
2.3.4 and 2.4.0-rc2
- 主要语言
- Starlark
- 星标
- 688
- 派生
- 723
- 平均合并
- 2 天 4 小时
- 30 天内合并 PR
- 38
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
bazel-contrib/rules_python 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
bazel-contrib/rules_python#4201 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
bazel-contrib/rules_python#4164 · 1 条评论 ·
维护者通常 1 天内回复
-
go:embed stdlib_list.txt file in gazelle/python/std_modules.go is missing可能已有人在做 @udaya2899 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
bazel-contrib/rules_python#3821 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 35/100
bazel-contrib/rules_python#4216 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
bazel-contrib/rules_python#4198 · 3 条评论 ·
维护者通常 1 天内回复
查看 bazel-contrib/rules_python 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 67/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
gfx-rs/wgpu-native#636 ·
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复