py_console_script_binary and gazelle modules_mapping warn about implicit __init__.py even after explicit_init_py(default = True)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 68/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- python
- Área
- build-system
Línea de trabajo
Start with the affected entry points: python/entry_points/py_console_script_binary.bzl and the py_console_script_gen_py target, then inspect the modules_mapping generator and merger targets in rules_python_gazelle_plugin. Run the Bazel reproduction with explicit_init_py(default = True) and --incompatible_default_to_explicit_init_py. Done means the three warnings disappear while the generated outputs remain byte-identical and the console script still runs.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
🐞 bug report
Affected Rule
The issue is caused by the rule: py_console_script_binary (its generator, @rules_python//python/private:py_console_script_gen_py) and the gazelle plugin's modules_mapping (@rules_python_gazelle_plugin//modules_mapping:generator and :merger).
Is this a regression?
No. These tools have always relied on implicit __init__.py creation; the deprecation warning is what's new.
Description
The module-wide explicit_init_py setting (#3997) only covers the declaring module's own targets. These three py_binary tools belong to rules_python and rules_python_gazelle_plugin, which don't declare it for themselves or set legacy_create_init on the targets. So any module that uses py_console_script_binary or modules_mapping still gets the warning after opting itself in, and has nothing left to change.
The tools don't seem to need the implicit files. With --incompatible_default_to_explicit_init_py, the repro below builds byte-identical outputs (the generated entry point and the modules-mapping JSON), and the console script still runs. So legacy_create_init = 0 on the three targets, or explicit_init_py(default = True) in both modules, looks sufficient.
The three targets are unchanged on main. py_console_script_gen_py was also mentioned in a comment on #2945.
🔬 Minimal Reproduction
MODULE.bazel:
bazel_dep(name = "rules_python", version = "2.3.4")
bazel_dep(name = "rules_python_gazelle_plugin", version = "2.3.4")
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
python.toolchain(python_version = "3.13")
pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
pip.parse(
hub_name = "pypi",
python_version = "3.13",
requirements_lock = "//:requirements.txt",
)
use_repo(pip, "pypi")
rules_python_config = use_extension("@rules_python//python/extensions:config.bzl", "config")
rules_python_config.explicit_init_py(default = True)
BUILD.bazel:
load("@pypi//:requirements.bzl", "all_whl_requirements")
load("@rules_python//python/entry_points:py_console_script_binary.bzl", "py_console_script_binary")
load("@rules_python_gazelle_plugin//modules_mapping:def.bzl", "modules_mapping")
py_console_script_binary(
name = "pyflakes",
pkg = "@pypi//pyflakes",
)
modules_mapping(
name = "modules_map",
wheels = all_whl_requirements,
)
requirements.txt:
pyflakes==3.4.0
bazel build --nobuild //...
🔥 Exception or Error
WARNING: Target @@rules_python_gazelle_plugin+//modules_mapping:generator is using implicit __init__.py creation.
WARNING: Target @@rules_python_gazelle_plugin+//modules_mapping:merger is using implicit __init__.py creation.
WARNING: Target @@rules_python+//python/private:py_console_script_gen_py is using implicit __init__.py creation.
🌍 Your Environment
Operating System:
macOS (arm64); the same three warnings on Linux x86_64 and aarch64
Output of bazel version:
Build label: 9.2.0
Rules_python version:
2.3.4 and 2.4.0-rc2
- Lenguaje dominante
- Starlark
- Estrellas
- 688
- Forks
- 723
- Merge medio
- 1 d 15 h
- PR fusionados (30 d)
- 40
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de bazel-contrib/rules_python
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
bazel-contrib/rules_python#4201 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
bazel-contrib/rules_python#4164 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
bazel-contrib/rules_python#3821 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
bazel-contrib/rules_python#4198 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
bazel-contrib/rules_python#4196 ·
Los mantenedores suelen responder en 1 día
Todos los issues de bazel-contrib/rules_python
Issues similares
-
<!-- appimagehub-test-result -->Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
AppImage/appimage.github.io#9676 ·
Los mantenedores suelen responder en 1 día
-
Flutter Improvement Waiting for: Product Owner
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
getsentry/sentry-dart#4061 · 2 comentarios ·
Los mantenedores suelen responder en 3 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Cocoanetics/SwiftBash#95 ·
-
Xcode 27Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
airbnb/HorizonCalendar#349 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
OpenwaterHealth/openmotion-bloodflow-app#696 · 4 comentarios ·
Los mantenedores suelen responder en 1 día