HTTP header list parsing does not accept empty list elements

未关闭
#1,396 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
scala

调研方向

Start with the list parsing rules used by HttpHeader.parse and compare them with Range’s existing handling of leading empty elements. Check downstream handling of unrecognized Connection headers, especially whether close is honored. Done when leading, interior, and trailing empty elements parse as required across list headers, the all-empty case is decided for required lists, and tests cover these cases.

由索引模型根据 Issue 内容生成。

描述

RFC 9110 §5.6.1 (previously RFC 7230 §7) says a recipient must parse and ignore a reasonable number of empty list elements. Most header list rules use oneOrMore(...).separatedBy(listSep) or the zeroOrMore equivalent, which does not allow them, so these headers are not parsed into their modeled types and stay RawHeaders:

Header Value
Cache-Control no-store,, public
Cache-Control , no-store, public
Cache-Control no-store, public,
Connection close,, foo
Allow GET,, POST
If-None-Match "a",, "b"
Accept text/plain,, text/html

These were found by parsing each value with HttpHeader.parse. They are a sample, and other headers using the same rules are likely to behave the same way. Range already tolerates leading empty elements with zeroOrMore(ws(',')).

Things to look at:

  • Interior, leading and trailing empty elements all need handling, so this probably means changing each list rule or adding a shared helper, not only listSep.
  • Decide how a list with no elements at all (for example Cache-Control: ,) should behave for headers that require at least one.
  • Check what happens downstream when a header stays a RawHeader, starting with Connection, since a close that is not recognised could change connection handling.

Follow-up to #1395, which fixes whitespace before the list separator but does not change how empty elements are handled.

主要语言
Scala
星标
199
派生
57
平均合并
1 天 20 小时
30 天内合并 PR
54

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/pekko-http 的其他 Issue

查看 apache/pekko-http 的全部 Issue

相似的 Issue

更多 Scala Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。