Native Iceberg errors print data and delete file paths with their credentials

未关闭 适合新手
#7,559 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
73/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust, scala
领域
backend, security

调研方向

阅读 iceberg_location_scoped.rs、iceberg_scan.rs、iceberg_write.rs 和 planner.rs,以及 #7127 中添加的 URL 脱敏辅助函数。找到列出的错误消息,并检查 #7128 的更改如何对类似路径应用脱敏。完成标准是每条消息打印的路径都不含凭据或查询字符串,且相关测试通过。

由索引模型根据 Issue 内容生成。

描述

requires-triage
Describe the bug

Found while working on #7128. Several native Iceberg errors print a data or delete file path exactly as the catalog recorded it:

  • iceberg_location_scoped.rs: "Invalid S3 path {path}", "S3 path {path} has no bucket"
  • iceberg_scan.rs: "Failed to stat delete file '{path}'" and the size check after it
  • iceberg_write.rs: "{path} is not the data file this output was made for", "... on the output of data file {path}"
  • planner.rs: "Delete file '{file_path}' has a negative {what}"

A location with a password in its userinfo or a SAS token or signature in its query string would end up in task failures and logs. Catalog locations rarely carry credentials, so this is low risk, but it is the same leak #7128 fixes for Parquet, Delta and object store paths.

Steps to reproduce

Each message formats the path with {path} as is, so a location like s3://alice:SECRET@bucket/t/delete.parquet?sig=TOKEN reaching any of them is printed with SECRET and TOKEN.

Expected behavior

These messages show the path without its password, username or query, using the URL redaction helpers #7127 adds, as the #7128 pull requests do for the other paths.

Additional context

Not part of the four #7128 pull requests, which cover object store setup, the Parquet writer, native Delta and the JVM rejected path reason.

主要语言
Scala
星标
1.3k
派生
414
平均合并
3 天 5 小时
30 天内合并 PR
228

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/datafusion-comet 的其他 Issue

查看 apache/datafusion-comet 的全部 Issue

相似的 Issue

更多 Scala Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。