Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

`ExecutorTool` resolves a non-ASF plugin into the test local repository

未关闭
#44 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
java
领域
build-system

调研方向

Read maven-executor/src/main/java/org/apache/maven/executor/support/ToolboxExecutorTool.java and the README first. Trace the existing localRepository(), artifactPath(), metadataPath(), and dump() behavior, then compare the path logic described for maven-verifier. Done means a non-plugin path implementation is available, Toolbox remains opt-in and documented, and the dependency/runtime wording is consistent.

由索引模型根据 Issue 内容生成。

描述

documentation enhancement
New feature, improvement proposal

The README describes maven-executor as dependency-less, and the POM agrees: the jar has no compile-scope dependencies. The only shipped ExecutorTool implementation does not, though. ToolboxExecutorTool answers localRepository(), artifactPath(), metadataPath(), and dump() by running eu.maveniverse.maven.plugins:toolbox:VERSION:gav-* through the Maven under test (ToolboxExecutorTool.java:45,134). Every consumer that needs an artifact path therefore fetches a plugin from a non-ASF group at test time, and the plugin and its transitive dependencies land in the local repository that the tests run against.

This matters for the projects that MIGRATION.md in maven-verifier tells to move here. maven-verifier computes those paths locally, and its integration tests assert on local-repository content: in maven-integration-testing alone deleteArtifacts is called 302 times and verifyArtifactPresent 84 times. After migration each of those calls depends on:

  • network access to Maven Central for a plugin outside the ASF, which offline and air-gapped CI cannot provide;
  • the toolbox artifacts appearing in the local repository under test, which changes what "artifact not present" assertions see;
  • a pinned third-party version (0.15.8 in the deprecated constructor, version.toolbox in the POM) that ASF release policy does not cover.

The maven-it-helper Verifier in apache/maven already carries this: it wires ToolboxExecutorTool at construction and reads version.toolbox from a system property, so the core ITs cannot run without the plugin.

Proposal:

  1. Provide an ExecutorTool implementation that computes local-repository, artifact, and metadata paths without executing a plugin. dump() needs Maven, but the three path methods only need the effective local repository and the standard layout, which maven-verifier has implemented for years and which Maven 3.9 and 4 share.
  2. Keep ToolboxExecutorTool as an opt-in for dump() and for anyone who wants the toolbox, and state in the README and Javadoc that it downloads and runs a third-party plugin.
  3. Change the README wording from "dependency-less" to describe the runtime requirement, or keep the wording once step 1 makes it true for the default path.

Context: apache/maven-verifier#186.

主要语言
Java
星标
5
派生
2
平均合并
4 小时 22 分钟
30 天内合并 PR
2

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/maven-executor 的其他 Issue

查看 apache/maven-executor 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。