`ExecutorTool` resolves a non-ASF plugin into the test local repository
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- java
- Área
- build-system
Línea de trabajo
Read maven-executor/src/main/java/org/apache/maven/executor/support/ToolboxExecutorTool.java and the README first. Trace the existing localRepository(), artifactPath(), metadataPath(), and dump() behavior, then compare the path logic described for maven-verifier. Done means a non-plugin path implementation is available, Toolbox remains opt-in and documented, and the dependency/runtime wording is consistent.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
New feature, improvement proposal
The README describes maven-executor as dependency-less, and the POM agrees: the jar has no compile-scope dependencies. The only shipped ExecutorTool implementation does not, though. ToolboxExecutorTool answers localRepository(), artifactPath(), metadataPath(), and dump() by running eu.maveniverse.maven.plugins:toolbox:VERSION:gav-* through the Maven under test (ToolboxExecutorTool.java:45,134). Every consumer that needs an artifact path therefore fetches a plugin from a non-ASF group at test time, and the plugin and its transitive dependencies land in the local repository that the tests run against.
This matters for the projects that MIGRATION.md in maven-verifier tells to move here. maven-verifier computes those paths locally, and its integration tests assert on local-repository content: in maven-integration-testing alone deleteArtifacts is called 302 times and verifyArtifactPresent 84 times. After migration each of those calls depends on:
- network access to Maven Central for a plugin outside the ASF, which offline and air-gapped CI cannot provide;
- the toolbox artifacts appearing in the local repository under test, which changes what "artifact not present" assertions see;
- a pinned third-party version (
0.15.8in the deprecated constructor,version.toolboxin the POM) that ASF release policy does not cover.
The maven-it-helper Verifier in apache/maven already carries this: it wires ToolboxExecutorTool at construction and reads version.toolbox from a system property, so the core ITs cannot run without the plugin.
Proposal:
- Provide an
ExecutorToolimplementation that computes local-repository, artifact, and metadata paths without executing a plugin.dump()needs Maven, but the three path methods only need the effective local repository and the standard layout, whichmaven-verifierhas implemented for years and which Maven 3.9 and 4 share. - Keep
ToolboxExecutorToolas an opt-in fordump()and for anyone who wants the toolbox, and state in the README and Javadoc that it downloads and runs a third-party plugin. - Change the README wording from "dependency-less" to describe the runtime requirement, or keep the wording once step 1 makes it true for the default path.
Context: apache/maven-verifier#186.
- Lenguaje dominante
- Java
- Estrellas
- 5
- Forks
- 2
- Merge medio
- 4 h 22 min
- PR fusionados (30 d)
- 2
Preparar el entorno
Aún no hemos revisado los archivos de configuración de este proyecto. Empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de apache/maven-executor
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
apache/maven-executor#46 ·
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 68/100
apache/maven-executor#50 ·
-
enhancement priority:major
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
apache/maven-executor#49 ·
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 78/100
apache/maven-executor#48 ·
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
apache/maven-executor#47 ·
Todos los issues de apache/maven-executor
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
ci-failure-cause test-failure
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
nextcloud/notes-android#3367 ·
Los mantenedores suelen responder en 1 día
-
Feature
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
MuntashirAkon/AppManager#2058 ·
-
SarifLogger: artifactLocation.uri is not properly encoded for file names containing '#', '?', or '%'Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
checkstyle/checkstyle#21721 ·
Los mantenedores suelen responder en 1 día