Big-endian compatibility failures in bucket hashing and Avro/deletion-vector serialization
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the linked MurmurHash block loads in src/iceberg/util/murmurhash3_internal.cc and the bucket hash golden vectors; the issue reports native word reads on big-endian systems. Then inspect the two decimal writers, the pinned Avro float/double routines, and the CRoaring serialization calls in src/iceberg/deletes/roaring_position_bitmap.cc. Add cross-endian fixtures for each reported wire format; done means the valid little-endian fixtures match and decode correctly on big-endian systems.
由索引模型根据 Issue 内容生成。
描述
Summary
Junwang (@zhjwpku) raised the big-endian question in the review of #998, which prompted this investigation.
An endian audit of main at 44e29e109e461e7c9069855c9a90442002580d23 found four compatibility problems on big-endian systems:
- Bucket hashes differ from Iceberg's specified values.
- Both Avro decimal writers produce incorrect big-endian decimal bytes.
- The configured Avro dependency uses native byte order for float/double serialization.
- The configured CRoaring dependency's portable serialization is little-endian-only, affecting deletion-vector bitmap payloads.
These are pre-existing findings, independent of #998. Representative failures were reproduced by executing actual s390x big-endian binaries under QEMU. This was a focused reproduction, not a full Iceberg build or integration test.
Verification scope
- Ubuntu 22.04.5 ARM64 container on a Mac; QEMU 6.2.0; s390x GCC/G++ 11.4.0; statically linked target binaries.
- ELF headers identify IBM S/390, big-endian, and the harness checks native byte order at runtime. No physical big-endian hardware was used.
- Native little-endian control tests pass.
- Murmur: complete, unchanged Iceberg source; blob
14cedabf4ac7b4ece349b52d05e254b86d2a5e8dmatches upstream. - Decimal: actual Arrow 25.0.0
BasicDecimal128storage plus the original statements from both Iceberg writers. Full Arrow arrays and Iceberg writers were not instantiated. - Avro: four unchanged float/double routine bodies from pinned commit
209a3735ec330679790824da54b7558db55e4e7f, using byte-copy stream substitutes. The full Avro library was not linked. - CRoaring: complete, unchanged 4.4.3 library and its original C++ wrapper, with no stubs.
Dependency findings below apply to the configured bundled versions. Custom dependency versions may differ.
1. Bucket hashing reads little-endian input as native words
getblock32 and getblock64 return p[i] without endian conversion. The x86_32 block loop uses these native loads. Although HashLong prepares little-endian input, the block reads interpret it incorrectly on a big-endian host.
Observed signed 32-bit hashes and bucket[100] results:
| Input | Expected hash | Actual s390x hash | Expected bucket | Actual bucket |
|---|---|---|---|---|
int/long 34 |
2017239379 | 1403955681 | 79 | 81 |
binary 00 01 02 03 |
-188683207 | 749933555 | 41 | 55 |
string iceberg |
1210000089 | 1578596666 | 89 | 66 |
The UUID golden vector also fails; a three-byte tail-only control passes. The failure is consistent with native full-block loads, rather than the byte-based tail handling.
This affects bucket transforms for numeric/date/time/timestamp/UUID inputs and byte/string inputs with full four-byte blocks. The same underlying hash code also affects object-store path hashing, with a lower interoperability impact.
Suggested direction: explicit little-endian, alignment-safe block loads, consistent with Iceberg's Appendix B 32-bit hash definition. Merely converting the input buffer to little-endian does not fix the subsequent native loads.
2. Avro decimal writers unconditionally reverse native bytes
Both direct encoder and data utility writer reverse the native decimal bytes unconditionally.
For a 16-byte decimal with unscaled value 1:
Expected big-endian wire: 00000000000000000000000000000001
Actual s390x wire: 01000000000000000000000000000000
Actual interpreted value: 2^120
On big-endian Arrow storage, the reversal corrupts the intended big-endian wire representation. Suggested direction: reverse only on little-endian hosts, or use an explicit big-endian conversion. The reader-side nanoarrow decimal copy is not the source of this failure.
3. Pinned Avro float/double routines use native wire order
The configured Avro revision's encoder and decoder copy native floating-point bytes, while Avro requires little-endian wire order.
| Value | Expected wire hex | Actual s390x wire hex | s390x decoding of valid little-endian wire |
|---|---|---|---|
float 1.0 |
0000803f |
3f800000 |
4.6006029882248069e-41 |
double 1.0 |
000000000000f03f |
3ff0000000000000 |
3.0386519416174186e-319 |
Same-host encode/decode round trips pass, hiding the cross-endian incompatibility. Both Iceberg Avro backends use the affected dependency. Suggested direction: fix/update the dependency or explicitly reject unsupported big-endian configurations until this is resolved.
4. CRoaring portable serialization is incompatible on big-endian hosts
Iceberg writes and reads the inner bitmap through CRoaring's portable serialization APIs.
With the complete CRoaring 4.4.3 library and bitmap {1}, the s390x execution:
- emits bytes different from the valid little-endian portable fixture;
- rejects that valid little-endian fixture when reading;
- successfully round-trips its own output.
CRoaring's 4.4.3 README explicitly limits serialization support to little-endian systems. Its writer and reader use native byte order.
Iceberg's outer deletion-vector header endian handling is correct; the inner serialized bitmap remains incompatible. Suggested direction: guard big-endian use of this path until the dependency provides compatible serialization.
Regression coverage
Cross-endian golden fixtures are needed in addition to same-host round trips: bucket hash vectors, decimal wire bytes, Avro float/double fixtures, and deletion-vector bitmap fixtures. A full Iceberg integration run on a big-endian target remains untested.
- 主要语言
- C++
- 星标
- 226
- 派生
- 133
- 平均合并
- 5 天 10 小时
- 30 天内合并 PR
- 33
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
apache/iceberg-cpp 的其他 Issue
-
bug: ReferenceVisitor::GetReferencedFieldIds dereferences null on a bound COUNT(*)可能已有人在做 @LuciferYang 于 11 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
apache/iceberg-cpp#978 ·
维护者通常 2 天内回复
-
bug: InMemoryCatalog skips the namespace existence check in CreateTable and RegisterTable可能已有人在做 @LuciferYang 于 11 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
apache/iceberg-cpp#977 ·
维护者通常 2 天内回复
-
Support Iceberg table encryption (Java-compatible)可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 5/5 一周以上 新手友好度 8/100
apache/iceberg-cpp#988 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 5/5 一周以上 新手友好度 20/100
apache/iceberg-cpp#959 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
apache/iceberg-cpp#946 · 5 条评论 ·
维护者通常 2 天内回复
查看 apache/iceberg-cpp 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 76/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 65/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 77/100
ros-navigation/navigation2#6648 · 1 条评论 ·
维护者通常 1 天内回复
-
[BUG] OTA Requestor accepts reserved provider endpoint 0xFFFF可能已有人在做 @Chapoly1305 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
project-chip/connectedhomeip#74742 ·
维护者通常 1 天内回复