[Bug] themeRiver layout is wrong after `resize()`: `boundaryGap` keeps the pixel values of the first layout

未关闭 适合新手
#21,858 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃

调研方向

报告者指出 themeRiverLayout 是 seriesModel.get('boundaryGap') 被就地解析的位置,因此请从那里开始,检查 option 数组是否被修改。用示例代码复现:先 resize,然后与最终尺寸下的新图表进行比较,并在前后检查 getOption().series[0].boundaryGap。当重复布局的结果与新图表一致,且 option 数组保留百分比字符串时,即完成。

由索引模型根据 Issue 内容生成。

描述

en pending
Version

6.1.0 (also current master 34f4d927e)

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?code=fZJBS8NAEIXv_RXvlgRCkxgqGqkgnlWQ3koP2zpN1mazYXcrxtL_7uzGitDiJSTzZr598za6d1J3mOMwAUQnlfDfFbaitZRyzcqubunhU9oKB7ihpwqRk4qiFE73Fa7yFGvtnFYVyhzHMERGEg8sPRW_Uw0pepUfZCLfBLwJJ7gpvAPL6CovZllRZPkNwwvmRiJapX-FWy_MzoUiZ6E8CZeBQV5fAJbX50IA-tW8EHj-eVxNjneTLEMB3k6JHYGXwqYRxsE22jgyUyy4ZJ0hoSx2RH3o4ayyMSbUorfQ21DWRtayEy0aknXjqoklt-B09d7FcYL5PdTw6PFTQ1Z-UXw4dbI7TjvxQeV5ElyV3hUDAtkKxfjxekUtZIe40-6JTE3JFM_aNXyz3npXk00xnMZ-jL_vFRvX437aGNo4tGJgX_94ZOElnBiPB_MvYvbEHsvg8Rs&enc=deflate

option = {
  animation: false,
  singleAxis: { type: 'time', top: 20, bottom: 30 },
  series: [{
    type: 'themeRiver',
    data: [
      ['2015/11/08', 10, 'a'], ['2015/11/09', 15, 'a'], ['2015/11/10', 35, 'a'],
      ['2015/11/08', 35, 'b'], ['2015/11/09', 36, 'b'], ['2015/11/10', 20, 'b']
    ]
  }]
};
// 1 s: make the chart shorter. The streams keep the top/bottom gaps of the original height:
setTimeout(() => myChart.resize({ height: 200 }), 1000);
// 3 s: set the same option again (notMerge). Nothing changes, yet the streams jump to the correct layout:
setTimeout(() => myChart.setOption(option, true), 3000);
Steps to Reproduce
  1. Create the chart with the option above in a 240x390 container.
  2. Call myChart.resize({ width: 400, height: 300 }) (or resize the browser window when the container height is responsive).
  3. Compare with a chart created directly at 400x300. Setting the same option again with notMerge: true also fixes the layout.
Current Behavior

After the resize, the streams are laid out with the top and bottom gaps of the initial size. For example, when a 240x390 chart
is resized to 400x300, the streams are squeezed or shifted instead of filling the area like a fresh 400x300 chart.
myChart.getOption().series[0].boundaryGap also returns pixel numbers instead of the default ['10%', '10%'] ([34, 34] for the
240x390 chart, before and after the resize).

A setOption that only changes the size of the singleAxis (top, bottom, left or right) shows the same problem.

Expected Behavior

The layout after resize() is the same as a fresh chart at the final size, and boundaryGap in the option is left unchanged.

Environment
  • OS: any (also reproduced with the SVG renderer in Node.js SSR)
  • Browser: any
  • Framework: none
Any additional comments?

Cause: themeRiverLayout gets the array with seriesModel.get('boundaryGap') and then resolves the percentages in place
(boundaryGap[0] = parsePercent(boundaryGap[0], rect.height)). This overwrites the option array, so every later layout reuses
the pixel values from the first one. Copying the array before resolving fixes it; I can send a PR.

主要语言
TypeScript
星标
67.8k
派生
19.9k
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/echarts 的其他 Issue

查看 apache/echarts 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。