[Bug] String formatter templates only replace the first occurrence of `{a}`/`{b}`/`{c}`

未关闭 适合新手
#21,843 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

@0z5a 已经在做这个了。

开始于 2026年11月15日。

  • #21844 来自 @0z5a —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
80/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript

调研方向

从 src/util/format.ts 开始:formatTpl 会把 {a} 改写成 {a0},然后用 tpl.replace(wrapVar(alias), ...) 替换值,而字符串模式的 replace 只命中第一个匹配;formatTplSimple 有同样的缺陷。把两者都换成 replace-all,并保持插入值是字面量,这样 $ 的处理仍然成立,然后在 jest 单元测试中覆盖重复的 {b}/{c}、重复的索引变量和 formatTplSimple,并检查某个 series 标签格式化器会渲染出 Mon: 120 | Mon: 120。注意报告者说已经有带测试的补丁,所以在重复它之前先与维护者确认。

由索引模型根据 Issue 内容生成。

描述

en pending
Version

6.1.0 (also reproduced on current master 34f4d92 and release 8ca03d4)

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?code=b3B0aW9uID0gewogICAgeEF4aXM6IHsgdHlwZTogJ2NhdGVnb3J5JywgZGF0YTogWydNb24nLCAnVHVlJ10gfSwKICAgIHlBeGlzOiB7fSwKICAgIHNlcmllczogW3sKICAgICAgICB0eXBlOiAnYmFyJywKICAgICAgICBuYW1lOiAnU2FsZXMnLAogICAgICAgIGRhdGE6IFsxMjAsIDIwMF0sCiAgICAgICAgbGFiZWw6IHsgc2hvdzogdHJ1ZSwgZm9ybWF0dGVyOiAne2J9OiB7Y30gfCB7Yn06IHtjfScgfQogICAgfV0KfTsK&enc=base64

Steps to Reproduce
  1. Create a chart with this option:
option = {
    xAxis: { type: 'category', data: ['Mon', 'Tue'] },
    yAxis: {},
    series: [{
        type: 'bar',
        name: 'Sales',
        data: [120, 200],
        label: { show: true, formatter: '{b}: {c} | {b}: {c}' }
    }]
};
  1. Look at the bar labels.

The same thing happens with the public helper:

echarts.format.formatTpl('{b}: {c} | {b}: {c}', {
    $vars: ['seriesName', 'name', 'value'], seriesName: 'Sales', name: 'Mon', value: 120
});
// 6.1.0 returns "Mon: 120 | {b}: {c}"

Rendered label text for three formatters, read back from the chart in the repo's jest unit-test setup. The first and third are controls (each variable used once, and a repeated {@[0]}):

"{b}: {c}"                           -> ["Mon: 120","Tue: 200"]
"{b}: {c} | {b}: {c}"                -> ["Mon: 120 | {b}: {c}","Tue: 200 | {b}: {c}"]
"{@[0]} | {@[0]}"                    -> ["120 | 120","200 | 200"]
Current Behavior

Only the first occurrence of each template variable is substituted. Later occurrences of the same variable are shown literally, e.g. the label reads Mon: 120 | {b}: {c}. Indexed variables in multi-series templates behave the same way: '{a0}={c0}, {a1}={c1}; {a0}={c0}, {a1}={c1}' gives A=1, B=2; {a0}={c0}, {a1}={c1}.

Expected Behavior

Every occurrence of a variable is replaced: Mon: 120 | Mon: 120. The option manual for series label.formatter lists {a}, {b}, {c}, {@xxx} and {@[n]} as string template variables (and tooltip.formatter lists {a} to {e} plus {a0}, {a1}, ...), and it does not say a variable can only be used once. In the same formatter, {@xxx} dimension variables are already replaced at every occurrence, and so are the time tokens ({yyyy}, {MM}, ...) in time axis label templates.

Environment
- OS: macOS 26 (arm64)
- Browser: not browser specific (reproduced in Node.js 24 with dist/echarts.js 6.1.0, and in the repo's jest/jsdom unit tests)
- Framework: none
Any additional comments?

Root cause: formatTpl in src/util/format.ts calls tpl.replace(wrapVar(alias), ...) with a string pattern, both when it rewrites {a} to {a0} and when it inserts the values. String.prototype.replace with a string pattern replaces only the first match (ECMA-262). formatTplSimple, which is used for the calendar and matrix label formatters, has the same pattern. formatTpl is used for series label formatters, string tooltip.formatter templates and echarts.format.formatTpl.

Suggested fix: replace all occurrences in both functions, for example with a small str.split(search).join(value + '') helper. That keeps the inserted value literal, so the $ handling from #21751 still works. I have a patch with unit tests (repeated {b}/{c}, repeated indexed variables, formatTplSimple, a series label check) and can open a PR if that helps.

This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.

主要语言
TypeScript
星标
67.7k
派生
19.9k
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/echarts 的其他 Issue

查看 apache/echarts 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。