Shell tool: no upper bound on the timeout a model can ask for, so one call can hold a turn for hours

Abierto Apto para principiantes
#65,254 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
75/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
tooling

Línea de trabajo

Lee packages/opencode/src/tool/shell.ts para ver el manejo de timeouts de v1 y packages/core/src/tool/bash.ts para MAX_TIMEOUT_MS; compara la ruta de v2 en packages/core/src/tool/plugin/shell.ts. Reprodúcelo con un comando lento como sleep 3000 y timeout: 14400000, y luego limita el timeout en primer plano al máximo existente o a un valor configurado. Está terminado cuando un timeout solicitado largo ya no bloquea más allá del límite, y el comando sigue pasando a segundo plano en ese límite.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area/core platform/linux type/feature version/v2
Description

The shell tool takes whatever timeout the model sends. There's no upper bound, so one call can hold the turn for hours.

We run opencode headless for coding agent evals, with a 60 minute limit per run. In four runs the model (Kimi K3 and K3.1 Pro) started a full Gradle test suite with timeout set to 3600000, 7200000 and 14400000 ms. That suite takes about an hour in our environment, so the call never came back and the run got cut at the limit with no answer. Before that call each run had made 44 to 110 tool calls and all of them completed.

The timeout message also tells the model to "retry with a larger timeout value", so it pushes models toward big numbers. In one run the model went from 120 s to 30 minutes on the retry.

In 1.19.6, packages/opencode/src/tool/shell.ts only rejects a negative value and then uses params.timeout ?? defaultTimeoutMs. packages/core/src/tool/bash.ts has MAX_TIMEOUT_MS = 10 * 60 * 1_000 and checks it in its schema, but the shell tool doesn't use it.

From reading dev (fe8def685) a foreground call looks the same: packages/core/src/tool/plugin/shell.ts takes a NonNegativeInt and uses input.timeout || DEFAULT_TIMEOUT_MS. A command that's still running at its timeout moves to the background now, which is the behavior we want, but a model that asks for 4 hours still blocks for 4 hours first.

What I'd like is a maximum for the foreground timeout: 10 minutes like MAX_TIMEOUT_MS, or a setting for it. Past the maximum, move the command to the background on v2 or stop it on v1. For v1, just applying the existing MAX_TIMEOUT_MS in the shell tool would fix it for us.

Related: #63748 asks for a configurable default. This one is about the upper bound.

Plugins

A small internal hooks plugin. It doesn't change the timeout.

OpenCode version

1.19.5 (where we saw it). 1.19.6 and dev fe8def685 from reading the source.

Steps to reproduce
  1. Have the model call the shell tool with a slow command and a long timeout, for example sleep 3000 with timeout: 14400000.
  2. The call blocks until the command ends. Nothing gives the turn back to the model before that.
Screenshot

No response

Operating System

Linux (container)

Terminal

none, headless

Lenguaje dominante
TypeScript
Estrellas
227k
Forks
30.7k
Merge medio
3 h 57 min
PR fusionados (30 d)
484

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de anomalyco/opencode

Todos los issues de anomalyco/opencode

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.