fix(cli): launch Biome reliably in Windows architecture guards
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 78/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
- 领域
- cli, testing-qa
调研方向
Start in cli/tests/architecture/biome-guards-bite.arch.test.ts and run the Windows launch reproduction comparing node_modules/.bin/biome with the package entry point through Node. Trace biomeFindings() and its three planted positive cases, checking startup errors before findings are parsed while preserving ordinary nonzero lint results. Done means Biome launches on supported platforms and the positive guards receive their expected diagnostics.
由索引模型根据 Issue 内容生成。
描述
Following the request in https://github.com/ai-driven-dev/framework/issues/863#issuecomment-5719279915, this tracks the launcher defect separately from architecture path normalization.
At 83b0246e532d3f76491baabbc8b0b266f00e3590, cli/tests/architecture/biome-guards-bite.arch.test.ts builds BIOME from node_modules/.bin/biome and passes that path directly to spawnSync. On native Windows the launch returns status: null and error.code: ENOENT. Invoking the installed package through Node succeeds with exit 0 and prints Version: 2.5.11.
Environment: Windows, Node 22.23.1, pnpm 12.3.4 for the latest architecture-suite run. Existing dependencies were originally installed with pnpm 11.19.0 and --ignore-scripts; this is not a claim of a fresh installation under 12.3.4.
From cli/, this launch-only reproduction uses the same installed dependency for both attempts:
import { spawnSync } from "node:child_process";
import { resolve } from "node:path";
const direct = spawnSync(resolve("node_modules/.bin/biome"), ["--version"], {
encoding: "utf8",
});
const viaNode = spawnSync(process.execPath, [
resolve("node_modules/@biomejs/biome/bin/biome"), "--version",
], { encoding: "utf8" });
for (const [name, result] of [["shim", direct], ["node", viaNode]]) {
console.log(name, result.status, result.error?.code, result.stdout, result.stderr);
}
biomeFindings() does not inspect result.error or verify that the process started. It parses stdout/stderr and returns [] after a failed launch, which is indistinguishable from a successful invocation with no findings to a caller expecting a clean result. The planted positive cases do fail: the three tests for process.exit, process globals, and default exports all receive empty arrays instead of their expected diagnostics.
Expected: use a launcher that works on supported platforms, and surface process-start failures as explicit failures before parsing findings. Preserve ordinary nonzero lint results, since those carry the violations the guard is designed to assert.
The control above proves only executable startup, not lint correctness. No Biome launcher changes are included in the separate path-normalization contribution.
Affected file: cli/tests/architecture/biome-guards-bite.arch.test.ts
AI tool: Codex. CLI checkout version: 5.3.0. OS: Windows. Path normalization PR: #880.
- 主要语言
- TypeScript
- 星标
- 481
- 派生
- 45
- 平均合并
- 1 天 13 小时
- 30 天内合并 PR
- 77
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
ai-driven-dev/framework 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
ai-driven-dev/framework#1050 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
ai-driven-dev/framework#1035 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
ai-driven-dev/framework#1002 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
ai-driven-dev/framework#952 ·
维护者通常 1 天内回复
-
refactor(aidd-orchestrator): the check zone says when to stop, and reviews its axes in one round未关闭
难度 2/5 1-3 小时 新手友好度 76/100
ai-driven-dev/framework#887 ·
维护者通常 1 天内回复
查看 ai-driven-dev/framework 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
OpenPetsHQ/openpets#273 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
fritzprix/libr-agent#2161 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
blackboardsh/electrobun#581 ·
-
backlog-skill effort:xs frontend infra ready-for-agent
难度 2/5 1-3 小时 新手友好度 74/100
LucasSantana-Dev/Lucky#2862 ·
维护者通常 1 天内回复