Error Message issues due timestamp info

未关闭
#33 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
php
领域
api, backend

调研方向

The request handling starts in compass/app/Http/Controllers/Api.php, around line 137, where the incoming timestamp is passed on. The exception is thrown from Shard.php at line 199, so reproduce by sending a timestamp with a timezone offset to the API and read the stack trace from there. Done means an offset timestamp gets a proper API error response instead of the generic 'Whoops' page, and timestamps without an offset still work. The issue does not say whether offsets should be accepted and converted or rejected, so confirm that with the maintainer before choosing.

由索引模型根据 Issue 内容生成。

描述

I came up with an interesting problem here

https://github.com/aaronpk/Compass/blob/c17f7b2ee237061c9f5de8fb63771120239084c1/compass/app/Http/Controllers/Api.php#L137

I'm storing in the database using no timezone offset. So just Z. But, if I send in an API query with an offset in the timezone, it responds, Exception in Shard.php line 199:

It should respond with a proper API error instead of a "Whoops, looks like something went wrong." message.

Not sure if you have any thoughts on the practical problem I have here. The app I used to send the data didn't have the option to send timestamp with offset so I didn't. I usually figure it out later for display purposes.

主要语言
JavaScript
星标
143
派生
33
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

aaronpk/Compass 的其他 Issue

查看 aaronpk/Compass 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。