Error Message issues due timestamp info

Abierto
#33 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
php
Área
api, backend

Línea de trabajo

The request handling starts in compass/app/Http/Controllers/Api.php, around line 137, where the incoming timestamp is passed on. The exception is thrown from Shard.php at line 199, so reproduce by sending a timestamp with a timezone offset to the API and read the stack trace from there. Done means an offset timestamp gets a proper API error response instead of the generic 'Whoops' page, and timestamps without an offset still work. The issue does not say whether offsets should be accepted and converted or rejected, so confirm that with the maintainer before choosing.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

I came up with an interesting problem here

https://github.com/aaronpk/Compass/blob/c17f7b2ee237061c9f5de8fb63771120239084c1/compass/app/Http/Controllers/Api.php#L137

I'm storing in the database using no timezone offset. So just Z. But, if I send in an API query with an offset in the timezone, it responds, Exception in Shard.php line 199:

It should respond with a proper API error instead of a "Whoops, looks like something went wrong." message.

Not sure if you have any thoughts on the practical problem I have here. The app I used to send the data didn't have the option to send timestamp with offset so I didn't. I usually figure it out later for display purposes.

Lenguaje dominante
JavaScript
Estrellas
143
Forks
33
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de aaronpk/Compass

Todos los issues de aaronpk/Compass

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.