[Bug]: ListTasksResult rejects valid responses when pageSize ≠ number of returned tasks (InvalidParamsError)

已关闭
  • 哪里不对？
#1,260 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

已经有一个关联 PR 被合并了。

  • #1273 来自 @RaphaelFakhri —— 已合并

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
java, json
领域
api

调研方向

The strict check is in the compact constructor of jsonrpc-common/src/main/java/org/a2aproject/sdk/jsonrpc/common/wrappers/ListTasksResult.java; the error surfaces through ProtoUtils.FromProto.convert in the grpc utils. Pull request #1273 is already open against this issue, so review or build on that work rather than starting a parallel fix. Done means a response with pageSize 50 and 2 tasks parses into a ListTasksResult, with a test covering that case.

由索引模型根据 Issue 内容生成。

描述

What happened?

Component: jsonrpc-common (ListTasksResult), reached via the JSON-RPC client transport

Version: a2a-java-sdk-client 1.4.0.Final (JSON-RPC transport)

What happened

Client.listTasks(...) fails with InvalidParamsError whenever the server's response has a pageSize that differs from the number of tasks in tasks. In practice this is every page that isn't completely full.

org.a2aproject.sdk.spec.InvalidParamsError: pageSize must be equal to the number of tasks in the list. Got 50, but list has 2 tasks.
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.convert(ProtoUtils.java:200)
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.listTasksResult(ProtoUtils.java:344)
    at org.a2aproject.sdk.grpc.utils.JSONRPCUtils.parseResponseBody(JSONRPCUtils.java:325)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.unmarshalResponse(JSONRPCTransport.java:369)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.listTasks(JSONRPCTransport.java:181)
    at org.a2aproject.sdk.client.Client.listTasks(Client.java:408)
    at org.a2aproject.sdk.client.AbstractClient.listTasks(AbstractClient.java:213)
Steps to reproduce
  1. Run an A2A server whose ListTasks response returns the requested page size in pageSize. The Python a2a-sdk 1.1.2 InMemoryTaskStore and DatabaseTaskStore do this (page_size = params.page_size or 50, returned as-is).
  2. Create 2 tasks in one contextId.
  3. Call client.listTasks(ListTasksParams.builder().contextId(ctx).pageSize(50).build()).

The server responds with this (abridged):

{"jsonrpc":"2.0","id":"1","result":{"tasks":[{...},{...}],"nextPageToken":"","pageSize":50,"totalSize":2}}
Expected behaviour

The response parses into a ListTasksResult with 2 tasks.

Actual behaviour

InvalidParamsError, thrown from the ListTasksResult compact constructor:

if (pageSize != tasks.size()) {
    throw new IllegalArgumentException("pageSize must be equal to the number of tasks in the list. Got " + pageSize + ", but list has " + tasks.size() + " tasks.");
}

(jsonrpc-common/src/main/java/org/a2aproject/sdk/jsonrpc/common/wrappers/ListTasksResult.java)

Why this looks like an SDK bug

The A2A specification, §3.1.4 List Tasks, says:

  • Request pageSize: "The maximum number of tasks to return. The service may return fewer than this value."
  • Response pageSize: "The page size used for this response."

A server may therefore return fewer tasks than pageSize, and the response pageSize is the page size applied rather than the count of tasks returned. The strict equality check rejects responses the spec allows.

Suggested fix
  • Remove the pageSize != tasks.size() check. Keep pageSize >= 0 if wanted.
  • Optionally, if the intent really is "count returned", the spec wording for the response pageSize should be clarified. Either way the SDK and the spec should agree.
Workaround

I currently rewrite result.pageSize to tasks.length in a decorating A2AHttpClient before the SDK parses the response.

Relevant log output
org.a2aproject.sdk.spec.InvalidParamsError: pageSize must be equal to the number of tasks in the list. Got 50, but list has 2 tasks.
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.convert(ProtoUtils.java:200)
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.listTasksResult(ProtoUtils.java:344)
    at org.a2aproject.sdk.grpc.utils.JSONRPCUtils.parseResponseBody(JSONRPCUtils.java:325)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.unmarshalResponse(JSONRPCTransport.java:369)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.listTasks(JSONRPCTransport.java:181)
    at org.a2aproject.sdk.client.Client.listTasks(Client.java:408)
    at org.a2aproject.sdk.client.AbstractClient.listTasks(AbstractClient.java:213)
Code of Conduct
  • I agree to follow this project's Code of Conduct
主要语言
Java
星标
510
派生
196
平均合并
2 天 9 小时
30 天内合并 PR
50

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

a2aproject/a2a-java 的其他 Issue

查看 a2aproject/a2a-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。