[Bug]: ListTasksResult rejects valid responses when pageSize ≠ number of returned tasks (InvalidParamsError)

Fermée
  • Quelque chose ne va pas ?
#1,260 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Une pull request liée a déjà été fusionnée.

  • #1273 par @RaphaelFakhri — fusionnée

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
25/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
java, json
Domaine
api

Piste de recherche

The strict check is in the compact constructor of jsonrpc-common/src/main/java/org/a2aproject/sdk/jsonrpc/common/wrappers/ListTasksResult.java; the error surfaces through ProtoUtils.FromProto.convert in the grpc utils. Pull request #1273 is already open against this issue, so review or build on that work rather than starting a parallel fix. Done means a response with pageSize 50 and 2 tasks parses into a ListTasksResult, with a test covering that case.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

What happened?

Component: jsonrpc-common (ListTasksResult), reached via the JSON-RPC client transport

Version: a2a-java-sdk-client 1.4.0.Final (JSON-RPC transport)

What happened

Client.listTasks(...) fails with InvalidParamsError whenever the server's response has a pageSize that differs from the number of tasks in tasks. In practice this is every page that isn't completely full.

org.a2aproject.sdk.spec.InvalidParamsError: pageSize must be equal to the number of tasks in the list. Got 50, but list has 2 tasks.
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.convert(ProtoUtils.java:200)
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.listTasksResult(ProtoUtils.java:344)
    at org.a2aproject.sdk.grpc.utils.JSONRPCUtils.parseResponseBody(JSONRPCUtils.java:325)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.unmarshalResponse(JSONRPCTransport.java:369)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.listTasks(JSONRPCTransport.java:181)
    at org.a2aproject.sdk.client.Client.listTasks(Client.java:408)
    at org.a2aproject.sdk.client.AbstractClient.listTasks(AbstractClient.java:213)
Steps to reproduce
  1. Run an A2A server whose ListTasks response returns the requested page size in pageSize. The Python a2a-sdk 1.1.2 InMemoryTaskStore and DatabaseTaskStore do this (page_size = params.page_size or 50, returned as-is).
  2. Create 2 tasks in one contextId.
  3. Call client.listTasks(ListTasksParams.builder().contextId(ctx).pageSize(50).build()).

The server responds with this (abridged):

{"jsonrpc":"2.0","id":"1","result":{"tasks":[{...},{...}],"nextPageToken":"","pageSize":50,"totalSize":2}}
Expected behaviour

The response parses into a ListTasksResult with 2 tasks.

Actual behaviour

InvalidParamsError, thrown from the ListTasksResult compact constructor:

if (pageSize != tasks.size()) {
    throw new IllegalArgumentException("pageSize must be equal to the number of tasks in the list. Got " + pageSize + ", but list has " + tasks.size() + " tasks.");
}

(jsonrpc-common/src/main/java/org/a2aproject/sdk/jsonrpc/common/wrappers/ListTasksResult.java)

Why this looks like an SDK bug

The A2A specification, §3.1.4 List Tasks, says:

  • Request pageSize: "The maximum number of tasks to return. The service may return fewer than this value."
  • Response pageSize: "The page size used for this response."

A server may therefore return fewer tasks than pageSize, and the response pageSize is the page size applied rather than the count of tasks returned. The strict equality check rejects responses the spec allows.

Suggested fix
  • Remove the pageSize != tasks.size() check. Keep pageSize >= 0 if wanted.
  • Optionally, if the intent really is "count returned", the spec wording for the response pageSize should be clarified. Either way the SDK and the spec should agree.
Workaround

I currently rewrite result.pageSize to tasks.length in a decorating A2AHttpClient before the SDK parses the response.

Relevant log output
org.a2aproject.sdk.spec.InvalidParamsError: pageSize must be equal to the number of tasks in the list. Got 50, but list has 2 tasks.
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.convert(ProtoUtils.java:200)
    at org.a2aproject.sdk.grpc.utils.ProtoUtils$FromProto.listTasksResult(ProtoUtils.java:344)
    at org.a2aproject.sdk.grpc.utils.JSONRPCUtils.parseResponseBody(JSONRPCUtils.java:325)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.unmarshalResponse(JSONRPCTransport.java:369)
    at org.a2aproject.sdk.client.transport.jsonrpc.JSONRPCTransport.listTasks(JSONRPCTransport.java:181)
    at org.a2aproject.sdk.client.Client.listTasks(Client.java:408)
    at org.a2aproject.sdk.client.AbstractClient.listTasks(AbstractClient.java:213)
Code of Conduct
  • I agree to follow this project's Code of Conduct
Langage dominant
Java
Étoiles
510
Forks
196
Merge moyen
2 j 4 h
PR mergées (30 j)
57

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de a2aproject/a2a-java

Toutes les issues de a2aproject/a2a-java

Issues similaires

Plus d'issues Java

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.