Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

UNHEX() binary UUID comparisons silently return no rows (breaks Staatic)

未关闭
#538 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
php, sqlite
领域
backend, database

调研方向

Read translate_function_call() in packages/mysql-on-sqlite/src/sqlite/class-wp-mysql-on-sqlite.php and WP_SQLite_PDO_User_Defined_Functions::unhex() in packages/mysql-on-sqlite/src/sqlite/class-wp-sqlite-pdo-user-defined-functions.php. Reproduce the UUID equality and IN cases through the AST driver, then inspect existing tests for comparison coercion and CAST behavior. Done means MySQL-compatible UNHEX comparisons pass across binary and character operands, IN/NOT IN, joins, and numeric contexts while preserving existing CAST behavior.

由索引模型根据 Issue 内容生成。

描述

Description

The AST driver silently returns no matches when a binary column is compared with UNHEX(...), even when the stored bytes match. Equality and IN lookups are affected.

We encountered this with Staatic 1.13.2, which stores UUIDs in binary columns. Its Publications page crashes while hydrating an existing publication because the associated build lookup returns no row:

PublicationRepository::rowToPublication():
Argument #2 ($build) must be of type Staatic\Framework\Build, null given

The build and deployment records exist. Publication setup also reports that an inserted publication does not exist.

Environment
  • SQLite Database Integration 3.1.0; reproduced against commit 6546e4538b708a1d8a565a1d31688bd63b610fa3.
  • AST driver / pure-PHP parser.
  • Isolated reproduction and prototype tests: PHP 8.4.26, PDO SQLite 3.45.1, PHPUnit 8.5.56, in-memory databases.
  • Application where the issue was discovered: Staatic 1.13.2.
Minimal reproduction

Run these MySQL queries through the integration's AST driver (rather than directly against a native SQLite connection):

CREATE TABLE uuid_lookup_test (uuid BINARY(16) PRIMARY KEY);
INSERT INTO uuid_lookup_test
  VALUES (X'00112233445566778899AABBCCDDEEFF');

SELECT COUNT(*) AS matches FROM uuid_lookup_test
  WHERE uuid = UNHEX(REPLACE(
    '00112233-4455-6677-8899-aabbccddeeff', '-', ''));

SELECT COUNT(*) AS matches FROM uuid_lookup_test
  WHERE uuid IN (UNHEX(REPLACE(
    '00112233-4455-6677-8899-aabbccddeeff', '-', '')));

Expected: both counts are 1, matching MySQL behavior.

Actual: both counts are 0 on the unpatched driver. Reversed equality and a join using binary_column = UNHEX(hex_column) also fail in regression tests.

Cause identified during investigation

WP_SQLite_PDO_User_Defined_Functions::unhex() returns a PHP string from pack(). PDO SQLite exposes that callback result as SQLite TEXT, while the driver stores binary columns as BLOBs. The different SQLite storage classes cause matching bytes to compare unequal.

Relevant code at the reproduced commit:

Workaround and possible fix direction

A scoped query filter replacing prepared, valid UUID expressions with equivalent X'...' binary literals restores the Staatic lookups without changing stored records. This is only an application workaround; the driver needs to handle arbitrary tables, nested expressions, and runtime column arguments.

A local proof of concept adds this to translate_function_call(), using the already translated AST arguments:

case 'UNHEX':
    return sprintf( 'CAST(UNHEX(%s) AS BLOB)', implode( ', ', $args ) );

This cast alone is not a complete global fix. These comparisons both need to return 1 under MySQL semantics:

SELECT UNHEX('4142') = X'4142';
SELECT UNHEX('4142') = 'AB';

The cast-only prototype returns 1 for the first and 0 for the second. A complete fix needs MySQL-compatible operand coercion, including binary/character comparisons, IN/NOT IN, joins, and numeric contexts. Type-aware handling in binary-column predicates may be another approach. The existing translation of MySQL CAST(... AS BINARY) to TEXT COLLATE BINARY should retain its established behavior.

The decoder also has boundary discrepancies: UNHEX(NULL) returns an empty string, invalid hex can raise PHP pack() warnings, and odd-length input is decoded incorrectly. The prototype returns NULL for NULL/invalid input, permits the empty string, and prepends a zero for odd-length valid input (e.g. UNHEX(123) should produce X'0123'). MySQL warning 1411 emulation is outside that prototype's scope.

Recorded prototype validation

The local prototype includes the BLOB cast, decoder corrections, and 14 regression cases covering UUID lookups and mutations, runtime-column joins, empty/mixed-case hex, NUL/non-UTF-8 bytes, NULL/invalid input, odd-length/numeric input, and result-name compatibility.

  • Before: 10 failures and 4 errors across the 14 new cases.
  • After: 14 tests, 58 assertions, all passing.
  • Full package suite with the prototype: 1,057 tests, 1,429,652 assertions; no failures, 15 skipped, 2 incomplete.
  • WordPress coding standards passed for the three changed files.

These are results from the isolated local investigation. They do not cover the unresolved mixed binary/character comparison above or the full supported PHP/SQLite CI matrix. The prototype has not been deployed to production.

MySQL references
主要语言
PHP
星标
363
派生
72
平均合并
3 天 7 小时
30 天内合并 PR
13

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

WordPress/sqlite-database-integration 的其他 Issue

查看 WordPress/sqlite-database-integration 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。