UNHEX() binary UUID comparisons silently return no rows (breaks Staatic)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
調査の方向性
Read translate_function_call() in packages/mysql-on-sqlite/src/sqlite/class-wp-mysql-on-sqlite.php and WP_SQLite_PDO_User_Defined_Functions::unhex() in packages/mysql-on-sqlite/src/sqlite/class-wp-sqlite-pdo-user-defined-functions.php. Reproduce the UUID equality and IN cases through the AST driver, then inspect existing tests for comparison coercion and CAST behavior. Done means MySQL-compatible UNHEX comparisons pass across binary and character operands, IN/NOT IN, joins, and numeric contexts while preserving existing CAST behavior.
索引モデルが issue の本文から書いたものです。
説明
Description
The AST driver silently returns no matches when a binary column is compared with UNHEX(...), even when the stored bytes match. Equality and IN lookups are affected.
We encountered this with Staatic 1.13.2, which stores UUIDs in binary columns. Its Publications page crashes while hydrating an existing publication because the associated build lookup returns no row:
PublicationRepository::rowToPublication():
Argument #2 ($build) must be of type Staatic\Framework\Build, null given
The build and deployment records exist. Publication setup also reports that an inserted publication does not exist.
Environment
- SQLite Database Integration 3.1.0; reproduced against commit
6546e4538b708a1d8a565a1d31688bd63b610fa3. - AST driver / pure-PHP parser.
- Isolated reproduction and prototype tests: PHP 8.4.26, PDO SQLite 3.45.1, PHPUnit 8.5.56, in-memory databases.
- Application where the issue was discovered: Staatic 1.13.2.
Minimal reproduction
Run these MySQL queries through the integration's AST driver (rather than directly against a native SQLite connection):
CREATE TABLE uuid_lookup_test (uuid BINARY(16) PRIMARY KEY);
INSERT INTO uuid_lookup_test
VALUES (X'00112233445566778899AABBCCDDEEFF');
SELECT COUNT(*) AS matches FROM uuid_lookup_test
WHERE uuid = UNHEX(REPLACE(
'00112233-4455-6677-8899-aabbccddeeff', '-', ''));
SELECT COUNT(*) AS matches FROM uuid_lookup_test
WHERE uuid IN (UNHEX(REPLACE(
'00112233-4455-6677-8899-aabbccddeeff', '-', '')));
Expected: both counts are 1, matching MySQL behavior.
Actual: both counts are 0 on the unpatched driver. Reversed equality and a join using binary_column = UNHEX(hex_column) also fail in regression tests.
Cause identified during investigation
WP_SQLite_PDO_User_Defined_Functions::unhex() returns a PHP string from pack(). PDO SQLite exposes that callback result as SQLite TEXT, while the driver stores binary columns as BLOBs. The different SQLite storage classes cause matching bytes to compare unequal.
Relevant code at the reproduced commit:
Workaround and possible fix direction
A scoped query filter replacing prepared, valid UUID expressions with equivalent X'...' binary literals restores the Staatic lookups without changing stored records. This is only an application workaround; the driver needs to handle arbitrary tables, nested expressions, and runtime column arguments.
A local proof of concept adds this to translate_function_call(), using the already translated AST arguments:
case 'UNHEX':
return sprintf( 'CAST(UNHEX(%s) AS BLOB)', implode( ', ', $args ) );
This cast alone is not a complete global fix. These comparisons both need to return 1 under MySQL semantics:
SELECT UNHEX('4142') = X'4142';
SELECT UNHEX('4142') = 'AB';
The cast-only prototype returns 1 for the first and 0 for the second. A complete fix needs MySQL-compatible operand coercion, including binary/character comparisons, IN/NOT IN, joins, and numeric contexts. Type-aware handling in binary-column predicates may be another approach. The existing translation of MySQL CAST(... AS BINARY) to TEXT COLLATE BINARY should retain its established behavior.
The decoder also has boundary discrepancies: UNHEX(NULL) returns an empty string, invalid hex can raise PHP pack() warnings, and odd-length input is decoded incorrectly. The prototype returns NULL for NULL/invalid input, permits the empty string, and prepends a zero for odd-length valid input (e.g. UNHEX(123) should produce X'0123'). MySQL warning 1411 emulation is outside that prototype's scope.
Recorded prototype validation
The local prototype includes the BLOB cast, decoder corrections, and 14 regression cases covering UUID lookups and mutations, runtime-column joins, empty/mixed-case hex, NUL/non-UTF-8 bytes, NULL/invalid input, odd-length/numeric input, and result-name compatibility.
- Before: 10 failures and 4 errors across the 14 new cases.
- After: 14 tests, 58 assertions, all passing.
- Full package suite with the prototype: 1,057 tests, 1,429,652 assertions; no failures, 15 skipped, 2 incomplete.
- WordPress coding standards passed for the three changed files.
These are results from the isolated local investigation. They do not cover the unresolved mixed binary/character comparison above or the full supported PHP/SQLite CI matrix. The prototype has not been deployed to production.
MySQL references
- 主要言語
- PHP
- スター
- 363
- フォーク
- 72
- 平均マージ
- 3日 7時間
- マージ済み PR(30日)
- 13
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドなし
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
WordPress/sqlite-database-integration のほかの issue
-
MySQL-on-SQLite does not translate DATE arithmetic with INTERVAL HOUR対応中かも @samuelmbabhazi が 28 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
WordPress/sqlite-database-integration#454 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 40/100
WordPress/sqlite-database-integration#531 ·
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
WordPress/sqlite-database-integration#529 ·
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
WordPress/sqlite-database-integration#528 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 1〜2日 初心者へのやさしさ 52/100
WordPress/sqlite-database-integration#527 ·
メンテナーはふだん 1 日以内に返信
WordPress/sqlite-database-integration の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Spomky-Labs/pwa-bundle#476 ·
-
domain/discovery
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
neos/flow-development-collection#3639 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
The PHP version check in prepare.php still allows PHP 7.2 and 7.3対応中かも @ekamran が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
WordPress/phpunit-test-runner#359 ·
メンテナーはふだん 2 日以内に返信