[AArch64] A stub’s adrp page address becomes a data variable that truncates an unrelated jump table
维护者通常 2 天内回复
@bpotchik 已经在做这个了。
开始于 2026年10月21日。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 42/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- cpp
调研方向
Start by inspecting the attached repro.s, control.s, and check.py, then trace the AArch64 adrp analysis that creates the variable at 0x100003000 and the jump-table analysis at 0x100002f6c. Reproduce the difference with python3 check.py repro and python3 check.py control. Done means the repro’s table and branch include all 91 cases and the stub’s page address does not truncate the table.
由索引模型根据 Issue 内容生成。
描述
The following issue was identified, triaged and written by Claude Opus 5.5, I have read through it to make sure the information is coherent and useful.
Version and Platform (required):
- Binary Ninja Version: 6.1.10957-dev (build 2899315201)
- Edition: Ultimate
- OS: macOS
- OS Version: 26.6.2 (25G83)
- CPU Architecture: Apple M2 Ultra
Bug Description:
When a data variable starts inside a jump table, Binary Ninja ends the table at that variable. The table ends there even when the bounds check on the switch index allows more entries. Binary Ninja's own analysis can define such a variable inside a table.
A stub of the form adrp x16, target@PAGE; add x16, x16, target@PAGEOFF; br x16 loads a page address with adrp. Binary Ninja defines an auto void data variable at that address. The stub uses the page address only to compute the branch target. When the page address falls inside a jump table elsewhere in __text, Binary Ninja ends the table at the variable. Binary Ninja's analysis of the switch then misses the remaining cases. The linear sweep makes a function out of each missed case.
In the attached repro, _main has a 91-case switch:
cmp w16, #0x5a
b.hi default
adrp x17, table@PAGE
add x17, x17, table@PAGEOFF
ldrsw x16, [x17, x16, lsl #2]
adr x17, base
add x16, x17, x16
br x16
Its table runs from 0x100002f6c to 0x1000030d8, across the page boundary at 0x100003000. _target_stub at 0x100001000 branches to _target at 0x1000030d8, whose page is 0x100003000.
Binary Ninja then:
- defines a
voiddata variable at0x100003000, whose only code reference is the stub'sadrpat0x100001000; - types the table at
0x100002f6casuint32_t[0x25], which is 37 entries ending at that variable; - gives the
br x16at0x10000202c37 of its 91 targets; - makes 54 functions out of the missed cases,
sub_1000021ectosub_100002468.
control is built from the same source without _target_stub. Its table is uint32_t[0x5b], the br has all 91 targets, and no other function starts inside _main. repro gave the same result on three runs.
Steps To Reproduce:
- Unzip the attachment and open
reproin Binary Ninja with default settings. Wait for analysis to finish. - Go to
0x100003000. Avoiddata variable is defined there, with one code reference, from_target_stubat0x100001000. - Go to
0x100002f6c. The jump table is typeduint32_t[0x25]. - Go to the
br x16at0x10000202cin_main. It has 37 targets. The functionssub_1000021ectosub_100002468start inside_main's case code. - Open
controlthe same way. Its table isuint32_t[0x5b], and thebrhas 91 targets.
check.py prints the same facts headless: python3 check.py repro, then python3 check.py control.
Expected Behavior:
cmp w16, #0x5a; b.hi limits the table at 0x100002f6c to 91 entries. Binary Ninja should read all 91, and the br x16 in _main should have all 91 targets, as it does in control.
The stub uses the page address 0x100003000 only to compute _target's address. Binary Ninja should not define a data variable there.
Screenshots/Video Recording:
N/A
Binary:
quick space launches inferentially
The sources repro.s and control.s, the binaries built from them with clang -arch arm64 <file>.s -o <file>, and check.py.
Additional Information:
- Measured headless with default settings and user plugins disabled (
BN_DISABLE_USER_PLUGINS=1). - Two changes would each give
reprothe resultcontrolgets: reading as many entries as the bounds check allows, or not defining a variable at the stub's page address. The code states the table's size, and a variable inside the table should not shorten the table. - Workaround: define a data variable, auto or user, over the whole table before analysis. With
int32_t[91]defined at0x100002f6cfirst, Binary Ninja does not define a variable at0x100003000, thebrhas 91 targets, and no function starts inside_main. - Only the
adrp/add/brstub pattern was tested.
- 主要语言
- C++
- 星标
- 1.3k
- 派生
- 304
- 平均合并
- 2 天 20 小时
- 30 天内合并 PR
- 10
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Vector35/binaryninja-api 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 84/100
Vector35/binaryninja-api#8715 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
Vector35/binaryninja-api#8714 ·
维护者通常 2 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
Vector35/binaryninja-api#8713 ·
维护者通常 2 天内回复
-
难度 1/5 1-3 小时 新手友好度 78/100
Vector35/binaryninja-api#8689 ·
维护者通常 2 天内回复
-
Component: Python API
难度 2/5 1-3 小时 新手友好度 70/100
Vector35/binaryninja-api#8649 ·
维护者通常 2 天内回复
查看 Vector35/binaryninja-api 的全部 Issue
相似的 Issue
-
Bug Core VIF
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
ESPresense/ESPresense#2680 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1 小时以内 新手友好度 75/100
stew675/llama-cpp-rdna-boosts#348 ·
维护者通常 1 天内回复
-
Documentation: Add comprehensive newcomer onboarding guide, project structure, and local usage to README可能已有人在做 @Ash-Blanc 今天认领。 未关闭area/other status/bot-triaged status/need-triage
难度 2/5 半天 新手友好度 85/100
-
bug
难度 1/5 1 小时以内 新手友好度 85/100
维护者通常 1 天内回复