[AArch64] A stub’s adrp page address becomes a data variable that truncates an unrelated jump table

未關閉
#8,672 8 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

維護者通常 2 天內回覆

@bpotchik 已經在處理了。

開始於 2026年10月21日。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
42/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
cpp

研究方向

Start by inspecting the attached repro.s, control.s, and check.py, then trace the AArch64 adrp analysis that creates the variable at 0x100003000 and the jump-table analysis at 0x100002f6c. Reproduce the difference with python3 check.py repro and python3 check.py control. Done means the repro’s table and branch include all 91 cases and the stub’s page address does not truncate the table.

由索引模型根據 Issue 內容生成。

描述

The following issue was identified, triaged and written by Claude Opus 5.5, I have read through it to make sure the information is coherent and useful.


Version and Platform (required):

  • Binary Ninja Version: 6.1.10957-dev (build 2899315201)
  • Edition: Ultimate
  • OS: macOS
  • OS Version: 26.6.2 (25G83)
  • CPU Architecture: Apple M2 Ultra

Bug Description:
When a data variable starts inside a jump table, Binary Ninja ends the table at that variable. The table ends there even when the bounds check on the switch index allows more entries. Binary Ninja's own analysis can define such a variable inside a table.

A stub of the form adrp x16, target@PAGE; add x16, x16, target@PAGEOFF; br x16 loads a page address with adrp. Binary Ninja defines an auto void data variable at that address. The stub uses the page address only to compute the branch target. When the page address falls inside a jump table elsewhere in __text, Binary Ninja ends the table at the variable. Binary Ninja's analysis of the switch then misses the remaining cases. The linear sweep makes a function out of each missed case.

In the attached repro, _main has a 91-case switch:

cmp   w16, #0x5a
b.hi  default
adrp  x17, table@PAGE
add   x17, x17, table@PAGEOFF
ldrsw x16, [x17, x16, lsl #2]
adr   x17, base
add   x16, x17, x16
br    x16

Its table runs from 0x100002f6c to 0x1000030d8, across the page boundary at 0x100003000. _target_stub at 0x100001000 branches to _target at 0x1000030d8, whose page is 0x100003000.

Binary Ninja then:

  • defines a void data variable at 0x100003000, whose only code reference is the stub's adrp at 0x100001000;
  • types the table at 0x100002f6c as uint32_t[0x25], which is 37 entries ending at that variable;
  • gives the br x16 at 0x10000202c 37 of its 91 targets;
  • makes 54 functions out of the missed cases, sub_1000021ec to sub_100002468.

control is built from the same source without _target_stub. Its table is uint32_t[0x5b], the br has all 91 targets, and no other function starts inside _main. repro gave the same result on three runs.

Steps To Reproduce:

  1. Unzip the attachment and open repro in Binary Ninja with default settings. Wait for analysis to finish.
  2. Go to 0x100003000. A void data variable is defined there, with one code reference, from _target_stub at 0x100001000.
  3. Go to 0x100002f6c. The jump table is typed uint32_t[0x25].
  4. Go to the br x16 at 0x10000202c in _main. It has 37 targets. The functions sub_1000021ec to sub_100002468 start inside _main's case code.
  5. Open control the same way. Its table is uint32_t[0x5b], and the br has 91 targets.

check.py prints the same facts headless: python3 check.py repro, then python3 check.py control.

Expected Behavior:
cmp w16, #0x5a; b.hi limits the table at 0x100002f6c to 91 entries. Binary Ninja should read all 91, and the br x16 in _main should have all 91 targets, as it does in control.

The stub uses the page address 0x100003000 only to compute _target's address. Binary Ninja should not define a data variable there.

Screenshots/Video Recording:
N/A

Binary:
quick space launches inferentially

The sources repro.s and control.s, the binaries built from them with clang -arch arm64 <file>.s -o <file>, and check.py.

Additional Information:

  • Measured headless with default settings and user plugins disabled (BN_DISABLE_USER_PLUGINS=1).
  • Two changes would each give repro the result control gets: reading as many entries as the bounds check allows, or not defining a variable at the stub's page address. The code states the table's size, and a variable inside the table should not shorten the table.
  • Workaround: define a data variable, auto or user, over the whole table before analysis. With int32_t[91] defined at 0x100002f6c first, Binary Ninja does not define a variable at 0x100003000, the br has 91 targets, and no function starts inside _main.
  • Only the adrp/add/br stub pattern was tested.
主要語言
C++
星號
1.3k
分支
304
平均合併
2 天 20 小時
30 天內合併 PR
10

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

Vector35/binaryninja-api 的其他 Issue

查看 Vector35/binaryninja-api 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。