Bug: Personal Vault stores plaintext passwords and allows unsafe note paths
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- python
调研方向
The payload names only users.json and the note-path construction under each user's vault; it does not name source files or tests. Start by finding where the login check compares passwords and where note names are joined into paths. Done means passwords are stored and verified with a salted hash from the standard library, note names are validated so they cannot leave the vault directory, and a test covers both. Scope is open, so confirm the approach with maintainers first.
由索引模型根据 Issue 内容生成。
描述
Repository commit
unknown
Python version (python --version)
Python 3.x
Dependencies version (pip freeze)
The app uses a local users.json file and standard library modules only. No dependency list was provided for the sample application.
Expected behavior
The Personal Vault application should not store passwords in plaintext, and note filenames should be validated before being used to construct filesystem paths. The login flow should verify credentials securely and user note operations should remain confined to the current vault directory.
Actual behavior
The sample application stores each password in users.json as plaintext and compares it directly during login. It accepts arbitrary note names and uses them to build paths under the user's vault without validating or normalizing them. This can allow credential disclosure and filesystem access outside the intended vault directory, and file operations can crash or behave unexpectedly when an invalid path is used.
- 主要语言
- Python
- 星标
- 226k
- 派生
- 51.3k
- 平均合并
- 8 小时 58 分钟
- 30 天内合并 PR
- 4
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TheAlgorithms/Python 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
TheAlgorithms/Python#15763 ·
维护者通常 1 天内回复
-
binomial_distribution overflows at 171 trials even when the result is representable可能已有人在做 @landfvit 于 19 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
TheAlgorithms/Python#15656 · 3 条评论 ·
维护者通常 1 天内回复
-
continued_fraction uses float division, producing invalid terms for large integers and raising OverflowError可能已有人在做 @trleo 于 19 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 88/100
TheAlgorithms/Python#15655 · 2 条评论 ·
维护者通常 1 天内回复
-
ciphers/base32.py and ciphers/base85.py encode Unicode code points instead of bytes: output diverges from the spec for non-ASCII, round-trips corrupt chars >= U+0400, arbitrary bytes crash可能已有人在做 @Nate-br 于 21 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
TheAlgorithms/Python#15636 · 1 条评论 ·
维护者通常 1 天内回复
-
ciphers/des_ecb.py: encrypt/decrypt silently corrupts any character above U+00FF (round-trip fails)可能已有人在做 @mohammedanasnakhuda 于 21 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
TheAlgorithms/Python#15634 ·
维护者通常 1 天内回复
查看 TheAlgorithms/Python 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 78/100
-
Needs Triage
难度 2/5 1-3 小时 新手友好度 80/100
pandas-dev/pandas#72163 ·
维护者通常 2 天内回复
-
LightFM prepare_test_df ignores mapping values and silently mislabels evaluation pairs可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 79/100
recommenders-team/recommenders#2480 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
521xueweihan/HelloGitHub#4385 ·
-
🐛 bug
难度 2/5 1-3 小时 新手友好度 72/100
pdm-project/pdm#4012 ·
维护者通常 1 天内回复