Bug: Personal Vault stores plaintext passwords and allows unsafe note paths

Abierto
#15,759 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python

Línea de trabajo

The payload names only users.json and the note-path construction under each user's vault; it does not name source files or tests. Start by finding where the login check compares passwords and where note names are joined into paths. Done means passwords are stored and verified with a salted hash from the standard library, note names are validated so they cannot leave the vault directory, and a test covers both. Scope is open, so confirm the approach with maintainers first.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Repository commit

unknown

Python version (python --version)

Python 3.x

Dependencies version (pip freeze)

The app uses a local users.json file and standard library modules only. No dependency list was provided for the sample application.

Expected behavior

The Personal Vault application should not store passwords in plaintext, and note filenames should be validated before being used to construct filesystem paths. The login flow should verify credentials securely and user note operations should remain confined to the current vault directory.

Actual behavior

The sample application stores each password in users.json as plaintext and compares it directly during login. It accepts arbitrary note names and uses them to build paths under the user's vault without validating or normalizing them. This can allow credential disclosure and filesystem access outside the intended vault directory, and file operations can crash or behave unexpectedly when an invalid path is used.

Lenguaje dominante
Python
Estrellas
226k
Forks
51.3k
Merge medio
8 h 58 min
PR fusionados (30 d)
4

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TheAlgorithms/Python

Todos los issues de TheAlgorithms/Python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.