Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

sorts: make algorithms sort any comparable items, not just ints

未关闭 适合新手
  • 哪里不对？
#15,234 91 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
74/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
data

调研方向

选择 sorts/ 中一个尚未勾选的比较排序算法，并使用 insertion_sort.py 作为 Comparable/TypeVar 模式的参考实现。将可比较的非整数情况和 TypeError 情况添加为 doctest，并添加到 tests/test_sorts.py 中。完成的标准是：该算法保留元素类型，拒绝混合的不可比较输入，并继续由相关测试覆盖。

由索引模型根据 Issue 内容生成。

描述

enhancement good first issue hacktoberfest tracking issue

Many of our sorts/ implementations are written and tested only against list[int], even though most comparison sorts work for any items that support <. This issue collects the small, well-scoped changes that make them correctly typed and tested for the general case — a good batch of beginner-friendly PRs for Hacktoberfest.

The type hint to use

Comparison sorts need items that are orderable, not Any. Model that with a small Protocol and a TypeVar bound to it:

from typing import Protocol


class Comparable(Protocol):
    def __lt__(self, other: object, /) -> bool: ...


def bubble_sort[T: Comparable](collection: list[T]) -> list[T]:
    ...

list[T] (with T bound to Comparable) is more precise than list[Any]: it says "a list of items that can be compared with each other" and preserves the element type in the return.

Note: counting/radix/bucket/pigeonhole sorts are not comparison sorts — they rely on integer keys. Those should keep their integer-specific hints and are out of scope here.

The tests to add

For each comparison sort, cover a comparable non-int type and the failure mode. Add both a doctest and a case in tests/test_sorts.py:

# succeeds: strings are comparable
assert bubble_sort(["c", "a", "b"]) == ["a", "b", "c"]

# succeeds: floats and ints are comparable
assert bubble_sort([2.5, -1, 0.0]) == [-1, 0.0, 2.5]

# raises: mixing non-comparable types must not silently mis-sort
import pytest

with pytest.raises(TypeError):
    bubble_sort([1, "a"])          # '<' not supported between int and str

The TypeError case matters: a sort that "succeeds" on non-comparable input is a correctness bug, so the test should assert the exception rather than a result.

How to contribute
  • Pick one comparison sort from sorts/ (comment which one so we don't double up).
  • Switch Any → the Comparable/TypeVar pattern above.
  • Add the succeed + raise cases as doctests and to tests/test_sorts.py.
  • Keep it to one algorithm per PR so reviews stay quick.
  • Link this issue without closing it: reference it as Part of #15234 or Ref #15234 in your PR description — not Closes/Fixes/Resolves #15234. A closing keyword makes GitHub auto-close this umbrella issue when your PR merges, even though other checkboxes remain. This issue should stay open until every box is checked.

I'll help review these and update the checklist below. Refs #15081.

Sort algorithms that can sort any comparable items

  • adaptive_merge_sort.py
  • bead_sort.py -- not a comparison sort
  • binary_insertion_sort.py
  • bitonic_sort.py -- needs a power-of-two length
  • bogo_sort.py
  • bubble_sort.py
  • bubble_sort_recursive
  • bucket_sort.py -- not a comparison sort
  • circle_sort.py
  • cocktail_shaker_sort.py
  • comb_sort.py
  • counting_sort.py -- not a comparison sort
  • cycle_sort.py
  • cyclic_sort.py
  • double_sort.py
  • dutch_national_flag_sort.py -- expects only 0/1/2
  • exchange_sort.py
  • external_sort.py
  • flash_sort.py -- not a comparison sort
  • gnome_sort.py
  • heap_sort.py
  • insertion_sort.py -- a good reference implementation to study <--
  • intro_sort.py
  • iterative_merge_sort.py
  • kirkpatrick_reisch_sort.py -- not a comparison sort
  • merge_insertion_sort.py
  • merge_sort.py
  • msd_radix_sort.py -- not a comparison sort
  • natural_sort.py
  • odd_even_sort.py
  • odd_even_transposition_parallel.py
  • odd_even_transposition_single_threaded.py
  • pancake_sort.py
  • patience_sort.py
  • pigeon_sort.py -- not a comparison sort
  • pigeonhole_sort.py -- not a comparison sort
  • power_sort.py
  • quick_sort.py
  • quick_sort_3_partition.py
  • radix_sort.py -- not a comparison sort
  • recursive_insertion_sort.py
  • recursive_mergesort_array.py
  • recursive_quick_sort.py
  • reversort.py
  • reverse_selection.py
  • selection_sort.py
  • shell_sort.py
  • shrink_shell_sort.py
  • slowsort.py
  • smoothsort.py
  • stalin_sort.py -- causes data loss!
  • stooge_sort.py
  • strand_sort.py
  • tim_sort.py
  • topological_sort.py -- sorts directed acyclic graphs
  • tree_sort.py
  • unknown_sort.py
  • wiggle_sort.py -- deliberately doesn't fully sort
主要语言
Python
星标
225k
派生
51.1k
平均合并
16 小时 12 分钟
30 天内合并 PR
180

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

TheAlgorithms/Python 的其他 Issue

查看 TheAlgorithms/Python 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。