Redirect from an effect during a pending navigation livelocks since router-core 1.171.16 (state.location alternates, nothing commits)

未关闭
#8,762 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@Sheraff 已经在做这个了。

开始于 2026年10月18日。

评估

这个 Issue 还没有评估数据。

描述

Which project does this relate to?

Router (in a Start app)

Describe the bug

Seen in a TanStack Start app; a standalone minimal repro is still pending (details below).

Starting with @tanstack/router-core 1.171.16 (#7805, the lane-based scheduler), a redirect issued from a component effect while another navigation is still pending can livelock. state.location keeps alternating between the two destinations, neither navigation commits, and the page stops responding.

The pattern (a root-level "gate" that sends the user to another route):

function Root() {
  const path = useRouterState({ select: (s) => s.location.pathname })
  const navigate = useNavigate()
  useEffect(() => {
    if (path !== '/') return
    navigate({ to: '/step', replace: true })
  }, [path, navigate])
  return <Outlet />
}

The sequence we observe:

  1. On /login, a successful sign-in calls navigate({ to: '/' }). That navigation is still pending (status: 'pending', resolvedLocation = /login).
  2. The root re-renders with location.pathname === '/', and the effect calls navigate({ to: '/step', replace: true }).
  3. From here state.location.pathname alternates /step, /, /step, / … on successive renders. resolvedLocation stays /login, status stays 'pending', and the browser URL never moves. The switch back to / happens before the effect's second navigate call. It looks as though the superseded / navigation re-publishes its location over the newer pending one.
  4. Because the effect is keyed on location.pathname, it sees / again and re-issues the navigation. Each re-issue settles the pending transition as superseded (Transitioner: settleOwner(acknowledgement, false)), and the cycle repeats.

On a production build this showed up as an intermittent hang. On the Vite dev server it happens every time. Measured there, the root component renders about 6,500 times a second and navigate is called about 1,700 times a second. The renderer pins a core, and CDP calls (Runtime.evaluate, Performance.enable) stop answering.

Captured router state per render (loc = state.location.pathname):

loc=/login  resolved=/login status=idle
loc=/       resolved=/login status=pending   <- navigation after sign-in, still pending
loc=/step   resolved=/login status=pending   <- effect: navigate({ to: '/step', replace: true })
loc=/       resolved=/login status=pending   <- reverted before any second navigate call
loc=/step   resolved=/login status=pending
loc=/       resolved=/login status=pending
… (indefinitely)
Bisect

We bisected over @tanstack/react-start releases (each pins its router packages). Same app code throughout:

react-start react-router / router-core result
1.168.35 1.170.18 / 1.171.15 redirect commits
1.168.36 1.170.19 / 1.171.16 livelock
1.168.42 1.170.25 / 1.171.21 (react-store still 0.9.3) livelock
1.168.60 1.170.41 / 1.171.34 livelock
1.168.61 1.170.42 / 1.171.35 livelock
react-router 1.170.45 / router-core 1.171.38 (forced) livelock

router-core 1.171.16 is the release that contains #7805.

Standalone repro attempts (none reproduce yet)

All on a bare Vite + React app with @tanstack/react-router 1.170.41, code-based routes, and the effect above, with /step having a 50 ms loader:

  1. Start at /. The redirect commits (4 renders).
  2. Start at /login; a button navigates to /, whose loader takes 50 ms, then 2 s, so the effect fires while / is pending. The redirect commits.
  3. As (2), plus an unrelated setState in the root every 20 ms. The redirect commits (308 renders).

Ingredients present in the Start app and absent from these attempts:

  • the Start client entry, with hydration of a server-rendered first document;
  • a beforeLoad on / that can throw redirect(). Disabling it did not stop the loop in the app, so it is probably not required;
  • the redirect target being a lazily loaded file route.

We'll update this issue if we get a standalone repro.

Expected behavior

While navigations overlap, state.location moves toward the latest requested navigation and does not revert to a superseded one. The latest navigation commits.

Workaround

Decide the redirect on the committed location (resolvedLocation?.pathname ?? location.pathname), and issue at most one navigation per (committed route, target). With that, our previously hanging cases pass every time.

Platform
  • @tanstack/react-start 1.168.60, @tanstack/react-router 1.170.41, @tanstack/router-core 1.171.34
  • React 19, Vite 7, Chromium (Playwright), macOS and Linux CI
主要语言
TypeScript
星标
15.3k
派生
1.9k
平均合并
1 天 5 小时
30 天内合并 PR
46

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/router 的其他 Issue

查看 TanStack/router 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。