Redirect from an effect during a pending navigation livelocks since router-core 1.171.16 (state.location alternates, nothing commits)
Los mantenedores suelen responder en 1 día
@Sheraff ya está trabajando en esto.
Desde el 18/10/2026.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
Which project does this relate to?
Router (in a Start app)
Describe the bug
Seen in a TanStack Start app; a standalone minimal repro is still pending (details below).
Starting with @tanstack/router-core 1.171.16 (#7805, the lane-based scheduler), a redirect issued from a component effect while another navigation is still pending can livelock. state.location keeps alternating between the two destinations, neither navigation commits, and the page stops responding.
The pattern (a root-level "gate" that sends the user to another route):
function Root() {
const path = useRouterState({ select: (s) => s.location.pathname })
const navigate = useNavigate()
useEffect(() => {
if (path !== '/') return
navigate({ to: '/step', replace: true })
}, [path, navigate])
return <Outlet />
}
The sequence we observe:
- On
/login, a successful sign-in callsnavigate({ to: '/' }). That navigation is still pending (status: 'pending',resolvedLocation=/login). - The root re-renders with
location.pathname === '/', and the effect callsnavigate({ to: '/step', replace: true }). - From here
state.location.pathnamealternates/step,/,/step,/… on successive renders.resolvedLocationstays/login,statusstays'pending', and the browser URL never moves. The switch back to/happens before the effect's secondnavigatecall. It looks as though the superseded/navigation re-publishes its location over the newer pending one. - Because the effect is keyed on
location.pathname, it sees/again and re-issues the navigation. Each re-issue settles the pending transition as superseded (Transitioner:settleOwner(acknowledgement, false)), and the cycle repeats.
On a production build this showed up as an intermittent hang. On the Vite dev server it happens every time. Measured there, the root component renders about 6,500 times a second and navigate is called about 1,700 times a second. The renderer pins a core, and CDP calls (Runtime.evaluate, Performance.enable) stop answering.
Captured router state per render (loc = state.location.pathname):
loc=/login resolved=/login status=idle
loc=/ resolved=/login status=pending <- navigation after sign-in, still pending
loc=/step resolved=/login status=pending <- effect: navigate({ to: '/step', replace: true })
loc=/ resolved=/login status=pending <- reverted before any second navigate call
loc=/step resolved=/login status=pending
loc=/ resolved=/login status=pending
… (indefinitely)
Bisect
We bisected over @tanstack/react-start releases (each pins its router packages). Same app code throughout:
| react-start | react-router / router-core | result |
|---|---|---|
| 1.168.35 | 1.170.18 / 1.171.15 | redirect commits |
| 1.168.36 | 1.170.19 / 1.171.16 | livelock |
| 1.168.42 | 1.170.25 / 1.171.21 (react-store still 0.9.3) |
livelock |
| 1.168.60 | 1.170.41 / 1.171.34 | livelock |
| 1.168.61 | 1.170.42 / 1.171.35 | livelock |
| react-router 1.170.45 / router-core 1.171.38 (forced) | livelock |
router-core 1.171.16 is the release that contains #7805.
Standalone repro attempts (none reproduce yet)
All on a bare Vite + React app with @tanstack/react-router 1.170.41, code-based routes, and the effect above, with /step having a 50 ms loader:
- Start at
/. The redirect commits (4 renders). - Start at
/login; a button navigates to/, whose loader takes 50 ms, then 2 s, so the effect fires while/is pending. The redirect commits. - As (2), plus an unrelated
setStatein the root every 20 ms. The redirect commits (308 renders).
Ingredients present in the Start app and absent from these attempts:
- the Start client entry, with hydration of a server-rendered first document;
- a
beforeLoadon/that canthrow redirect(). Disabling it did not stop the loop in the app, so it is probably not required; - the redirect target being a lazily loaded file route.
We'll update this issue if we get a standalone repro.
Expected behavior
While navigations overlap, state.location moves toward the latest requested navigation and does not revert to a superseded one. The latest navigation commits.
Workaround
Decide the redirect on the committed location (resolvedLocation?.pathname ?? location.pathname), and issue at most one navigation per (committed route, target). With that, our previously hanging cases pass every time.
Platform
@tanstack/react-start1.168.60,@tanstack/react-router1.170.41,@tanstack/router-core1.171.34- React 19, Vite 7, Chromium (Playwright), macOS and Linux CI
- Lenguaje dominante
- TypeScript
- Estrellas
- 15.3k
- Forks
- 1.9k
- Merge medio
- 1 d 5 h
- PR fusionados (30 d)
- 46
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de TanStack/router
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
Masked navigation drops the first character of the hash each time (__tempLocation hash missing '#')Posiblemente ocupada @hassanabrar202 la tomó hace 8 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
router-generator: lazy-load Prettier (costs ~300–450ms per build even when formatting is off)Posiblemente ocupada @Sheraff la tomó hace 27 días. Abiertopackage: router-generator performance
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
router-generator: sibling `physical()` subtrees in a virtual route config generate duplicate identifiersPosiblemente ocupada @Sheraff la tomó hace 27 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
docs(router): clarify static title fallback in SPA modePosiblemente ocupada @Rohan-Dedhia la tomó hace 17 días. Abierto
Dificultad 1/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
Todos los issues de TanStack/router
Issues similares
-
[BUG]: Shared links drop the configured basePath on GitHub PagesPosiblemente ocupada @anshulchikhale30-p la tomó hoy. Abiertobug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
StabilityNexus/IdentityTokens-EVM-Frontend#182 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Add: GTrekkerAbiertocheck:passed streams:add
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Koenkk/zigbee-herdsman-converters#13900 ·
Los mantenedores suelen responder en 1 día
-
area: ui Bug Payload OSS
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
payloadcms/payload#19839 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
jeanibarz/knowledge-base-mcp-server#1291 ·
Los mantenedores suelen responder en 1 día