useQueries: stable combine returns a stale result when a query updates before setQueries runs

未关闭
#12,626 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@sakaintp 已经在做这个了。

开始于 2026年11月19日。

  • #12632 来自 @sakaintp —— 未关闭
  • #12633 来自 @yashhbeladiya —— 未关闭
  • #12638 来自 @mgarcia-improving —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
62/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
react, typescript
领域
frontend

调研方向

Start in packages/query-core/src/queriesObserver.ts: read #combineResult, #notify and getOptimisticResult in that order, and note that only the last passes queryHashes while #notify does not. Reproduce first by running the gist's repro.mjs against a local build (npm i, then node repro.mjs) and confirm the final line prints 3 instead of 5. Done means the combined result tracks the current query list and a regression test alongside the existing QueriesObserver tests covers the case where a query updates between render and setQueries.

由索引模型根据 Issue 内容生成。

描述

[!NOTE]
🤖 Claude Opus 5.5 responding on behalf of swheel33

Describe the bug

useQueries with a stable combine can return a combined result built from the previous query list, so its length no longer matches the queries passed in on that render. Code that indexes the combined result by the input list (results[index].data) then throws: we hit TypeError: Cannot read properties of undefined in our app.

This is a gap left by #9954 (the fix for #8781). #combineResult now detects a changed query list by comparing queryHashes with #lastQueryHashes, but only getOptimisticResult passes queryHashes. #notify calls #combineResult without them, so it recomputes from the observer's current results (the old list) while #lastQueryHashes still holds the new list from the last render. On the next render the hashes look unchanged, #result === #lastResult, and the stale combined result is returned.

Sequence:

  1. Render with queries A (3 queries). The effect calls setQueries(A).
  2. Render with queries B (5 queries). getOptimisticResult combines 5 results and sets #lastQueryHashes = B.
  3. Before the effect calls setQueries(B), a query in A updates. #onUpdate → #notify → #combineResult combines the 3 results of A and caches them, leaving #lastQueryHashes = B.
  4. The listener re-renders with B. #combineResult sees no change and returns the 3-item result.
Your minimal, reproducible example

https://gist.github.com/swheel33/2f38c4065d592f58a8046917c405252e

Steps to reproduce
npm i @tanstack/[email protected]
node repro.mjs

Output:

render with 3 queries -> 3
render with 5 queries -> 5
re-render with 5 queries -> 3 (expected 5)

The script drives QueriesObserver the way useQueries does: getOptimisticResult per render, setQueries in an effect.

Expected behavior

The combined result reflects the queries passed on the current render, so the last line prints 5.

How often does this bug happen?

Sometimes

Platform
  • @tanstack/query-core 5.108.0 (also seen on 5.103.0)
  • @tanstack/react-query 5.103.0, React 19
  • OS: macOS, Browser: Chrome
Tanstack Query adapter

react-query

TanStack Query version

5.108.0

TypeScript version

N/A (the repro is plain JS)

Additional context

In the browser this happens when the list of queries grows (in our case, one balance query per token, and the token list grows when a wallet connects) and an existing query resolves between the render and the useQueries effect.

We worked around it with a local patch that has #notify pass the hashes of the results it combines, so the next render sees the list changed:

this.#combineResult(
  this.#trackResult(this.#result, this.#observerMatches),
  this.#options?.combine,
  this.#observerMatches.map((match) => match.defaultedQueryOptions.queryHash),
)
主要语言
TypeScript
星标
50.6k
派生
4.2k
平均合并
9 小时 50 分钟
30 天内合并 PR
310

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/query 的其他 Issue

查看 TanStack/query 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。