useQueries: stable combine returns a stale result when a query updates before setQueries runs

オープン
#12,626 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@sakaintp がすでに取り組んでいます。

2026年11月19日 から。

  • #12632 @sakaintp による — オープン
  • #12633 @yashhbeladiya による — オープン
  • #12638 @mgarcia-improving による — オープン

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
62/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
react, typescript
領域
frontend

調査の方向性

Start in packages/query-core/src/queriesObserver.ts: read #combineResult, #notify and getOptimisticResult in that order, and note that only the last passes queryHashes while #notify does not. Reproduce first by running the gist's repro.mjs against a local build (npm i, then node repro.mjs) and confirm the final line prints 3 instead of 5. Done means the combined result tracks the current query list and a regression test alongside the existing QueriesObserver tests covers the case where a query updates between render and setQueries.

索引モデルが issue の本文から書いたものです。

説明

[!NOTE]
🤖 Claude Opus 5.5 responding on behalf of swheel33

Describe the bug

useQueries with a stable combine can return a combined result built from the previous query list, so its length no longer matches the queries passed in on that render. Code that indexes the combined result by the input list (results[index].data) then throws: we hit TypeError: Cannot read properties of undefined in our app.

This is a gap left by #9954 (the fix for #8781). #combineResult now detects a changed query list by comparing queryHashes with #lastQueryHashes, but only getOptimisticResult passes queryHashes. #notify calls #combineResult without them, so it recomputes from the observer's current results (the old list) while #lastQueryHashes still holds the new list from the last render. On the next render the hashes look unchanged, #result === #lastResult, and the stale combined result is returned.

Sequence:

  1. Render with queries A (3 queries). The effect calls setQueries(A).
  2. Render with queries B (5 queries). getOptimisticResult combines 5 results and sets #lastQueryHashes = B.
  3. Before the effect calls setQueries(B), a query in A updates. #onUpdate → #notify → #combineResult combines the 3 results of A and caches them, leaving #lastQueryHashes = B.
  4. The listener re-renders with B. #combineResult sees no change and returns the 3-item result.
Your minimal, reproducible example

https://gist.github.com/swheel33/2f38c4065d592f58a8046917c405252e

Steps to reproduce
npm i @tanstack/[email protected]
node repro.mjs

Output:

render with 3 queries -> 3
render with 5 queries -> 5
re-render with 5 queries -> 3 (expected 5)

The script drives QueriesObserver the way useQueries does: getOptimisticResult per render, setQueries in an effect.

Expected behavior

The combined result reflects the queries passed on the current render, so the last line prints 5.

How often does this bug happen?

Sometimes

Platform
  • @tanstack/query-core 5.108.0 (also seen on 5.103.0)
  • @tanstack/react-query 5.103.0, React 19
  • OS: macOS, Browser: Chrome
Tanstack Query adapter

react-query

TanStack Query version

5.108.0

TypeScript version

N/A (the repro is plain JS)

Additional context

In the browser this happens when the list of queries grows (in our case, one balance query per token, and the token list grows when a wallet connects) and an existing query resolves between the render and the useQueries effect.

We worked around it with a local patch that has #notify pass the hashes of the results it combines, so the next render sees the list changed:

this.#combineResult(
  this.#trackResult(this.#result, this.#observerMatches),
  this.#options?.combine,
  this.#observerMatches.map((match) => match.defaultedQueryOptions.queryHash),
)
主要言語
TypeScript
スター
50.6k
フォーク
4.2k
平均マージ
9時間 50分
マージ済み PR(30日)
310

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/query のほかの issue

TanStack/query の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。