Deletions mutations have incorrect `original` and `changes` if they were previously updated
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 52/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- data
调研方向
Start at Transaction.applyMutations, where pending mutations are merged and where delete mutations get original, modified and changes all set to the deletion-time row. Read how PendingMutation is built for deletes and what collection._state.syncedData holds, using the update-then-delete sandbox to reproduce. Done means a delete after an update reports original from before the transaction, modified from just before deletion, and changes as their diff, with a regression test covering bulk updates plus a delete.
由索引模型根据 Issue 内容生成。
描述
- I've validated the bug against the latest version of DB packages
Describe the bug
Deletion mutations have incorrect original and changes if they were previously updated.
To Reproduce
Steps to reproduce the behavior:
- Go to https://codesandbox.io/p/sandbox/yxwtgj
- Click on 'Update'
- Click on 'Delete'
- Observe that
originalandchangesare incorrect
Expected behavior
originalshould be the data since before the current transaction started,modifiedshould be the data before the deletion (might be the same asoriginalif no updates occurred during the transaction), andchangesshould be the difference betweenoriginalandmodified.
Additional context
I run the following fixDeletions workaround in Transaction.applyMutations, which I've monkey-patched:
function fixDeletions(
this: Transaction<any>,
mutations: PendingMutation<any>[],
): void {
// Merge via a globalKey-keyed map rather than a findIndex scan per
// mutation, which is O(n²) for bulk operations (e.g. inserting many rows
// in one call). Map preserves insertion order, matching the previous
// replace-in-place / remove / append semantics.
const merged = new Map<string, PendingMutation<any>>()
for (const mutation of this.mutations) {
merged.set(mutation.globalKey, mutation)
}
for (const newMutation of mutations) {
const { globalKey } = newMutation
if (newMutation.type !== 'delete') {
merged.set(globalKey, newMutation)
continue
}
// Deletions have `original`, `modified`, and `changes` set to the
// state at deletion time.
// `original` should be the actual original, `changes` should be the
// changes between `original` and `modified`
const original =
newMutation.collection._state.syncedData.get(newMutation.key) ?? newMutation.original
const { modified } = newMutation
const keys = new Set([...Object.keys(original), ...Object.keys(modified)])
const changes: Partial<Record<string, unknown>> = {}
for (const key of keys) {
if (
Object.hasOwn(original, key) !== Object.hasOwn(modified, key)
|| !sameRowValue(original[key], modified[key])
) {
changes[key] = modified[key]
}
}
merged.set(globalKey, {
...newMutation,
original,
changes,
})
}
// Rebuild in place to preserve the array's identity for external holders
this.mutations.length = 0
for (const mutation of merged.values()) {
this.mutations.push(mutation)
}
}
- 主要语言
- TypeScript
- 星标
- 4k
- 派生
- 286
- 平均合并
- 1 天 8 小时
- 30 天内合并 PR
- 105
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TanStack/db 的其他 Issue
-
extractSimpleComparisons returns value: null when the right side of a comparison isn't a literal未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
`avg`, `min`, `max` and `sum` treat `null` values as `0`可能已有人在做 @oyobbeb 于 11 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
`Collection.currentStateAsChanges` JSDoc examples don’t match `CurrentStateAsChangesOptions`可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 1/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
Two @tanstack/db tests time out under CPU load because a cold module import counts against the 5 s default timeout可能已有人在做 @jp-knj 于 23 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
相似的 Issue
-
inference/go type/feature
难度 1/5 1-3 小时 新手友好度 72/100
anomalyco/opencode#65148 · 1 条评论 ·
维护者通常 1 天内回复
-
truapi-release
难度 2/5 1-3 小时 新手友好度 72/100
paritytech/product-sdk#529 ·
维护者通常 1 天内回复
-
Add: Mansudae TV未关闭approved check:passed streams:add
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 1 天内回复
-
[Perf] Canvas layer composition is quadratic: splitRenderLayers re-copies the node array per node未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 77/100
devlikeapro/waha#2369 ·
维护者通常 5 天内回复