Deletions mutations have incorrect `original` and `changes` if they were previously updated

オープン
#2,447 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
52/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript
領域
data

調査の方向性

Start at Transaction.applyMutations, where pending mutations are merged and where delete mutations get original, modified and changes all set to the deletion-time row. Read how PendingMutation is built for deletes and what collection._state.syncedData holds, using the update-then-delete sandbox to reproduce. Done means a delete after an update reports original from before the transaction, modified from just before deletion, and changes as their diff, with a regression test covering bulk updates plus a delete.

索引モデルが issue の本文から書いたものです。

説明

  • I've validated the bug against the latest version of DB packages

Describe the bug
Deletion mutations have incorrect original and changes if they were previously updated.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/p/sandbox/yxwtgj
  2. Click on 'Update'
  3. Click on 'Delete'
  4. Observe that original and changes are incorrect

Expected behavior

  • original should be the data since before the current transaction started,
  • modified should be the data before the deletion (might be the same as original if no updates occurred during the transaction), and
  • changes should be the difference between original and modified.

Additional context
I run the following fixDeletions workaround in Transaction.applyMutations, which I've monkey-patched:

function fixDeletions(
  this: Transaction<any>,
  mutations: PendingMutation<any>[],
): void {
  // Merge via a globalKey-keyed map rather than a findIndex scan per
  // mutation, which is O(n²) for bulk operations (e.g. inserting many rows
  // in one call). Map preserves insertion order, matching the previous
  // replace-in-place / remove / append semantics.
  const merged = new Map<string, PendingMutation<any>>()
  for (const mutation of this.mutations) {
    merged.set(mutation.globalKey, mutation)
  }

  for (const newMutation of mutations) {
    const { globalKey } = newMutation

    if (newMutation.type !== 'delete') {
      merged.set(globalKey, newMutation)
      continue
    }

    // Deletions have `original`, `modified`, and `changes` set to the
    // state at deletion time.
    // `original` should be the actual original, `changes` should be the
    // changes between `original` and `modified`

    const original =
      newMutation.collection._state.syncedData.get(newMutation.key) ?? newMutation.original

    const { modified } = newMutation
    const keys = new Set([...Object.keys(original), ...Object.keys(modified)])
    const changes: Partial<Record<string, unknown>> = {}
    for (const key of keys) {
      if (
        Object.hasOwn(original, key) !== Object.hasOwn(modified, key)
        || !sameRowValue(original[key], modified[key])
      ) {
        changes[key] = modified[key]
      }
    }

    merged.set(globalKey, {
      ...newMutation,
      original,
      changes,
    })
  }

  // Rebuild in place to preserve the array's identity for external holders
  this.mutations.length = 0
  for (const mutation of merged.values()) {
    this.mutations.push(mutation)
  }
}
主要言語
TypeScript
スター
4k
フォーク
286
平均マージ
1日 8時間
マージ済み PR(30日)
105

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/db のほかの issue

TanStack/db の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。