CLI edge cases: rules accepts stray flags, locale-dependent sort, --fix scope
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
调研方向
Start with the listed sections of src/cli.ts, src/lint/project.ts, src/baseline.ts, and src/lint/rules/stringly-nodepath.ts, then inspect related cases in test/cli.test.ts. Run npm run build && npm test to see the current behavior. Done means each listed edge case has a documented decision or code change and a test; the issue describes several interacting CLI and fix-policy decisions.
由索引模型根据 Issue 内容生成。
描述
Summary
Small CLI edge cases left over after the strict-arguments work (#68) and the new --fix flag.
Where
src/cli.ts:315(rulesreturns before any flag validation)src/cli.ts:75-77,src/lint/project.ts:39-41,src/baseline.ts:69-71(localeComparewith no fixed locale)src/lint/rules/stringly-nodepath.ts:30-41,src/cli.ts:353-357(--fixscope)
Details and checklist
-
gdcorrect rulessilently accepts--fail-on bogus,--fix,--files,--baselineand--write-baseline. That contradicts the strict-CLI contract. Reject flags that do not apply torules, with exit 2. - Sorting with
a.localeCompare(b)and no fixed locale makes output order, and the order of entries in a written baseline file, depend on the machine's ICU locale. That can cause baseline diffs between developers and CI. Use a plain code-unit comparison, orlocaleCompare(b, "en"). - The
stringly-nodepathfix rewritesget_node("A/B")to$A/B. That is the same literal path, which the finding itself calls rename-fragile, so the fix hides the finding without addressing it.--fixalso applies every attached fix regardless of severity. Either:- reword the rule as a style preference, or
- add
--fix-rule <id>, or limit--fixto findings at or above--fail-on.
-
--fixruns before the baseline filter (cli.ts:353-364), so baselined findings are rewritten too. Decide whether that is intended, and document or change it.
Acceptance criteria
- Each item above is either changed or documented, with a test.
Getting started
- Relevant files:
src/cli.ts,src/lint/project.ts,src/baseline.ts,test/cli.test.ts - How to run tests:
npm run build && npm test
Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: quality|src/cli.ts|misc
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 6
- 平均合并
- 1 天 21 小时
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/godot-correctness-mcp 的其他 Issue
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/godot-correctness-mcp#123 ·
维护者通常 2 天内回复
-
dependencies good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/godot-correctness-mcp#116 ·
维护者通常 2 天内回复
-
bug good first issue severity: low
难度 2/5 1-3 小时 新手友好度 88/100
TMHSDigital/godot-correctness-mcp#107 ·
维护者通常 2 天内回复
-
bug good first issue severity: low
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/godot-correctness-mcp#106 ·
维护者通常 2 天内回复
-
bug good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 84/100
TMHSDigital/godot-correctness-mcp#105 ·
维护者通常 2 天内回复
查看 TMHSDigital/godot-correctness-mcp 的全部 Issue
相似的 Issue
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw#203385 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
nwverse/persona#12800 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 半天 新手友好度 65/100
维护者通常 1 天内回复