Hosted scan on a pnpm workspace with `sharedWorkspaceLockfile: false` ignores the per-package pnpm-lock.yaml files and reports success while redirecting nothing
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- rust
- 领域
- build-system, cli, devtools
调研方向
Start in crates/socket-patch-core/src/hosted/engine.rs at read_candidate_files and inspect crates/socket-patch-core/src/formats/pnpm/hosted.rs around redirect_pnpm_entry_not_found. Run the e2e_redirect_pnpm_build.rs harness against the sharedWorkspaceLockfile=false reproduction. Done means member pnpm-lock.yaml files are handled with the root workspace trust edit, or the scan fails closed instead of reporting success with no redirects.
由索引模型根据 Issue 内容生成。
描述
[agent] Found by the scheduled pnpm bug-hunt routine (ledger #303).
Summary
With sharedWorkspaceLockfile: false (shared-workspace-lockfile=false in .npmrc on older majors), pnpm writes one pnpm-lock.yaml per workspace package (packages/a/pnpm-lock.yaml, packages/b/pnpm-lock.yaml, …). The root pnpm-lock.yaml covers only the root importer, and is often just importers: .: {}.
scan --mode hosted from the workspace root finds the vulnerable package in node_modules, then reads only the root lock (plus the Rush locks when rush.json exists). The member locks that pnpm actually installs from are never opened. The run ends with exit 0, status: success, redirect.redirected: 0, rewrittenFiles: [], and one redirect_pnpm_entry_not_found warning ("no resolution for [email protected]"). Every package in the workspace keeps installing the unpatched registry tarball.
Impact
- Hosted mode silently does nothing on this documented pnpm layout.
success/ exit 0 tells CI and users the project is patched when no lock was changed. - VEX stays honest: with nothing pinned,
vexfinds nothing to attest. So the failure is "unpatched, but reported as a successful hosted scan", not a false attestation. - The obvious workaround fails on pnpm 11+. Running
scan --mode hosted --cwd packages/adoes pinpackages/a/pnpm-lock.yaml, but it also createspackages/a/pnpm-workspace.yaml(packages: ['.']+trustLockfile: true). That turns the member into a nested workspace root, and pnpm ignores the file when installing from the real root. A freshpnpm install --frozen-lockfilefrom the root on pnpm 12.8.1 then fails withERR_PNPM_TARBALL_URL_MISMATCH. - Vendored mode on the same layout refuses loudly (
vendor_lock_entry_not_found, partialFailure, exit 1), which is acceptable fail-closed behaviour.
Repro
mkdir -p ws/packages/a ws/packages/b && cd ws
echo '{"name":"root","version":"0.0.0","private":true}' > package.json
echo '{"name":"a","version":"1.0.0","dependencies":{"is-number":"7.0.0"}}' > packages/a/package.json
echo '{"name":"b","version":"1.0.0","dependencies":{"to-regex-range":"5.0.1"}}' > packages/b/package.json # [email protected] transitively
printf "packages:\n - 'packages/*'\nsharedWorkspaceLockfile: false\n" > pnpm-workspace.yaml
echo 'shared-workspace-lockfile=false' > .npmrc # pnpm <= 10 reads this
pnpm install
ls pnpm-lock.yaml packages/*/pnpm-lock.yaml # three locks; the root one is `importers: .: {}`
socket-patch scan --mode hosted --json --yes ... # patch for pkg:npm/[email protected] is available
# status: success, exit 0, redirect.redirected: 0, rewrittenFiles: [],
# warnings: [{code: redirect_pnpm_entry_not_found, detail: "no resolution for [email protected]"}]
grep -c 'tarball:' packages/*/pnpm-lock.yaml # 0 everywhere
# fresh checkout + pnpm install --frozen-lockfile -> both a and b load the upstream bytes
(I ran this against a local mock of the patch API: batch / by-package / package grant / view / hosted tarball, with SOCKET_PATCH_SERVER_URL and SOCKET_NPM_REGISTRY pointed at it, the same harness as the repo's e2e_redirect_pnpm_build.rs. The oracle is a marker prepended to is-number/index.js.)
Expected vs actual
- Expected: docs/ecosystems.md (npm hosted-mode notes) says pnpm "workspaces … are handled. Every matching package instance is rewritten; an unsupported instance prevents confirming that dependency across the lockfile set." A pnpm workspace's lockfile set includes its per-package locks when
sharedWorkspaceLockfileis false, so eachpackages/*/pnpm-lock.yamlthat resolves the package should be pinned, withtrustLockfilegoing into the rootpnpm-workspace.yaml. At minimum, the run should fail closed (partialFailure / non-zero, as vendored does) instead of reportingsuccess. - Actual: only the root lock is read, nothing is rewritten, and the status is
success, exit 0.
Matrix (Linux, main 61cfb9b)
| OS | pnpm | lock | hosted from the workspace root | vendored from the root |
|---|---|---|---|---|
| Linux | 8.15.9 | 6.0 | fail (success, 0 redirected) | not run |
| Linux | 9.15.9 | 9.0 | fail (2/2) | refuses vendor_lock_entry_not_found (OK) |
| Linux | 10.34.5 | 9.0 | fail | refuses (OK) |
| Linux | 11.28.3 | 9.0 | fail | refuses (OK) |
| Linux | 12.8.1 | 9.0 | fail (2/2) | refuses (OK) |
| Linux | 12.8.1 | 9.0 | workaround --cwd packages/a: lock pinned, but the root frozen install fails with ERR_PNPM_TARBALL_URL_MISMATCH |
Control: the same workspace with the default shared lock is redirected, installs patched bytes in both members, and rolls back byte for byte (passes on 9.15.9 / 10.34.5 / 11.28.3 / 12.8.1). macOS and Windows weren't probed, but the code path is OS-independent.
Not bisected. The 4.0.0 release can't be driven against the v5-shaped mock, and the candidate-file list has never included member locks.
Suspect code
crates/socket-patch-core/src/hosted/engine.rs:404(read_candidate_files): it readsREDIRECT_CANDIDATE_FILES(rootpnpm-lock.yaml), Cargo members, Python locks and the Rush locks (:449,rush_repo), but it never expands thepnpm-workspace.yamlpackages:globs into per-memberpnpm-lock.yamlkeys. The comment there notes that the pnpm rewriter is already basename-generalized for nested keys, so adding member locks (and pointing the trust edit at the root workspace file) looks like the shape of a fix.crates/socket-patch-core/src/formats/pnpm/hosted.rs:393:redirect_pnpm_entry_not_foundis a warning only, so the miss doesn't affect the status.
- 主要语言
- Rust
- 星标
- 8
- 派生
- 0
- 平均合并
- 1 天 7 分钟
- 30 天内合并 PR
- 178
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
SocketDev/socket-patch 的其他 Issue
-
Hosted yarn classic pins give no berry-migration warning, so a yarn 2+ install silently drops them (vendored warns about the same trap)可能已有人在做 @mikolalysenko 于 1 天前认领。 未关闭agent:claimed agent:triaged bug bughunt pm:yarn-classic priority:p1
难度 2/5 1-3 小时 新手友好度 85/100
SocketDev/socket-patch#907 · 2 条评论 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:npm priority:p1
难度 2/5 1-3 小时 新手友好度 75/100
SocketDev/socket-patch#900 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:bundler priority:p1
难度 2/5 1-3 小时 新手友好度 85/100
SocketDev/socket-patch#896 · 1 条评论 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:yarn-berry priority:p1
难度 2/5 1-3 小时 新手友好度 73/100
SocketDev/socket-patch#783 · 1 条评论 ·
维护者通常 1 天内回复
-
agent:triaged bug bughunt pm:pipenv priority:p1
难度 2/5 1-3 小时 新手友好度 83/100
SocketDev/socket-patch#744 · 1 条评论 ·
维护者通常 1 天内回复
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
agent/sec-check hive/hive-school-tunaos security
难度 2/5 1-3 小时 新手友好度 90/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
Sovereign-Labs/sovereign-sdk#3070 ·
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
area:prove bug
难度 2/5 1-3 小时 新手友好度 82/100
Chelis-Lang/chelis#3317 ·
维护者通常 1 天内回复
-
[macOS Desktop] New sidebar hover navigation accidentally switches sections while reaching a chat未关闭app bug
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复