Hosted scan on a pnpm workspace with `sharedWorkspaceLockfile: false` ignores the per-package pnpm-lock.yaml files and reports success while redirecting nothing
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 68/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- rust
- 領域
- build-system, cli, devtools
研究方向
Start in crates/socket-patch-core/src/hosted/engine.rs at read_candidate_files and inspect crates/socket-patch-core/src/formats/pnpm/hosted.rs around redirect_pnpm_entry_not_found. Run the e2e_redirect_pnpm_build.rs harness against the sharedWorkspaceLockfile=false reproduction. Done means member pnpm-lock.yaml files are handled with the root workspace trust edit, or the scan fails closed instead of reporting success with no redirects.
由索引模型根據 Issue 內容生成。
描述
[agent] Found by the scheduled pnpm bug-hunt routine (ledger #303).
Summary
With sharedWorkspaceLockfile: false (shared-workspace-lockfile=false in .npmrc on older majors), pnpm writes one pnpm-lock.yaml per workspace package (packages/a/pnpm-lock.yaml, packages/b/pnpm-lock.yaml, …). The root pnpm-lock.yaml covers only the root importer, and is often just importers: .: {}.
scan --mode hosted from the workspace root finds the vulnerable package in node_modules, then reads only the root lock (plus the Rush locks when rush.json exists). The member locks that pnpm actually installs from are never opened. The run ends with exit 0, status: success, redirect.redirected: 0, rewrittenFiles: [], and one redirect_pnpm_entry_not_found warning ("no resolution for [email protected]"). Every package in the workspace keeps installing the unpatched registry tarball.
Impact
- Hosted mode silently does nothing on this documented pnpm layout.
success/ exit 0 tells CI and users the project is patched when no lock was changed. - VEX stays honest: with nothing pinned,
vexfinds nothing to attest. So the failure is "unpatched, but reported as a successful hosted scan", not a false attestation. - The obvious workaround fails on pnpm 11+. Running
scan --mode hosted --cwd packages/adoes pinpackages/a/pnpm-lock.yaml, but it also createspackages/a/pnpm-workspace.yaml(packages: ['.']+trustLockfile: true). That turns the member into a nested workspace root, and pnpm ignores the file when installing from the real root. A freshpnpm install --frozen-lockfilefrom the root on pnpm 12.8.1 then fails withERR_PNPM_TARBALL_URL_MISMATCH. - Vendored mode on the same layout refuses loudly (
vendor_lock_entry_not_found, partialFailure, exit 1), which is acceptable fail-closed behaviour.
Repro
mkdir -p ws/packages/a ws/packages/b && cd ws
echo '{"name":"root","version":"0.0.0","private":true}' > package.json
echo '{"name":"a","version":"1.0.0","dependencies":{"is-number":"7.0.0"}}' > packages/a/package.json
echo '{"name":"b","version":"1.0.0","dependencies":{"to-regex-range":"5.0.1"}}' > packages/b/package.json # [email protected] transitively
printf "packages:\n - 'packages/*'\nsharedWorkspaceLockfile: false\n" > pnpm-workspace.yaml
echo 'shared-workspace-lockfile=false' > .npmrc # pnpm <= 10 reads this
pnpm install
ls pnpm-lock.yaml packages/*/pnpm-lock.yaml # three locks; the root one is `importers: .: {}`
socket-patch scan --mode hosted --json --yes ... # patch for pkg:npm/[email protected] is available
# status: success, exit 0, redirect.redirected: 0, rewrittenFiles: [],
# warnings: [{code: redirect_pnpm_entry_not_found, detail: "no resolution for [email protected]"}]
grep -c 'tarball:' packages/*/pnpm-lock.yaml # 0 everywhere
# fresh checkout + pnpm install --frozen-lockfile -> both a and b load the upstream bytes
(I ran this against a local mock of the patch API: batch / by-package / package grant / view / hosted tarball, with SOCKET_PATCH_SERVER_URL and SOCKET_NPM_REGISTRY pointed at it, the same harness as the repo's e2e_redirect_pnpm_build.rs. The oracle is a marker prepended to is-number/index.js.)
Expected vs actual
- Expected: docs/ecosystems.md (npm hosted-mode notes) says pnpm "workspaces … are handled. Every matching package instance is rewritten; an unsupported instance prevents confirming that dependency across the lockfile set." A pnpm workspace's lockfile set includes its per-package locks when
sharedWorkspaceLockfileis false, so eachpackages/*/pnpm-lock.yamlthat resolves the package should be pinned, withtrustLockfilegoing into the rootpnpm-workspace.yaml. At minimum, the run should fail closed (partialFailure / non-zero, as vendored does) instead of reportingsuccess. - Actual: only the root lock is read, nothing is rewritten, and the status is
success, exit 0.
Matrix (Linux, main 61cfb9b)
| OS | pnpm | lock | hosted from the workspace root | vendored from the root |
|---|---|---|---|---|
| Linux | 8.15.9 | 6.0 | fail (success, 0 redirected) | not run |
| Linux | 9.15.9 | 9.0 | fail (2/2) | refuses vendor_lock_entry_not_found (OK) |
| Linux | 10.34.5 | 9.0 | fail | refuses (OK) |
| Linux | 11.28.3 | 9.0 | fail | refuses (OK) |
| Linux | 12.8.1 | 9.0 | fail (2/2) | refuses (OK) |
| Linux | 12.8.1 | 9.0 | workaround --cwd packages/a: lock pinned, but the root frozen install fails with ERR_PNPM_TARBALL_URL_MISMATCH |
Control: the same workspace with the default shared lock is redirected, installs patched bytes in both members, and rolls back byte for byte (passes on 9.15.9 / 10.34.5 / 11.28.3 / 12.8.1). macOS and Windows weren't probed, but the code path is OS-independent.
Not bisected. The 4.0.0 release can't be driven against the v5-shaped mock, and the candidate-file list has never included member locks.
Suspect code
crates/socket-patch-core/src/hosted/engine.rs:404(read_candidate_files): it readsREDIRECT_CANDIDATE_FILES(rootpnpm-lock.yaml), Cargo members, Python locks and the Rush locks (:449,rush_repo), but it never expands thepnpm-workspace.yamlpackages:globs into per-memberpnpm-lock.yamlkeys. The comment there notes that the pnpm rewriter is already basename-generalized for nested keys, so adding member locks (and pointing the trust edit at the root workspace file) looks like the shape of a fix.crates/socket-patch-core/src/formats/pnpm/hosted.rs:393:redirect_pnpm_entry_not_foundis a warning only, so the miss doesn't affect the status.
- 主要語言
- Rust
- 星號
- 8
- 分支
- 0
- 平均合併
- 1 天 7 分鐘
- 30 天內合併 PR
- 178
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
SocketDev/socket-patch 的其他 Issue
-
Hosted yarn classic pins give no berry-migration warning, so a yarn 2+ install silently drops them (vendored warns about the same trap)可能已有人在做 @mikolalysenko 於 1 天前認領。 未關閉agent:claimed agent:triaged bug bughunt pm:yarn-classic priority:p1
難度 2/5 1-3 小時 新手友好度 85/100
SocketDev/socket-patch#907 · 2 則留言 ·
維護者通常 1 天內回覆
-
vendor --check fails a vendored package whose lock is contested by a sibling package-lock.json with "no lockfile or config references .socket/vendor/… any more", which is false, and its remedy ("re-run socket-patch vendor") is a no-op, so the check stays red forever可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉agent:triaged bug bughunt pm:npm priority:p1
難度 2/5 1-3 小時 新手友好度 75/100
SocketDev/socket-patch#900 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:bundler priority:p1
難度 2/5 1-3 小時 新手友好度 85/100
SocketDev/socket-patch#896 · 1 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:yarn-berry priority:p1
難度 2/5 1-3 小時 新手友好度 73/100
SocketDev/socket-patch#783 · 1 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:pipenv priority:p1
難度 2/5 1-3 小時 新手友好度 83/100
SocketDev/socket-patch#744 · 1 則留言 ·
維護者通常 1 天內回覆
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 70/100
joshstevens19/rindexer#483 ·
維護者通常 1 天內回覆
-
VX_PRINT_DROPS prints each drop point twice on the default code generator, the second time at line 0未關閉
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 66/100
CommunityToolkit/Aspire#2231 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100