Mixed npm and pnpm locks report an upgrade as applied without changing either lock

未关闭
  • 哪里不对？
#1,691 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
node.js, typescript
领域
cli, security

调研方向

Start by reproducing with the linked fixture and the exact socket fix commands, then compare the apply result with git diff and a fresh dry-run. Trace how the CLI detects and updates package-lock.json and pnpm-lock.yaml when both are present; the issue names no source files or tests. Done means each lock is either changed and reported accurately, or the mixed-lock condition is reported without claiming unchanged files or unresolved targets were applied.

由索引模型根据 Issue 内容生成。

描述

Mixed npm and pnpm locks report an upgrade as applied without changing either lock

Environment

  • Socket CLI 1.8.2, Coana CLI 15.12.11
  • Node.js 26.13.0, npm 11.20.0, pnpm 10.28.0
  • Linux container; lifecycle scripts disabled
  • Public dependencies only

Reproduction

Public fixture (manifest and both generated lockfiles): https://gist.github.com/ivan-novaprime/ae77a24cb98cc19e9afa0a0f9a108218

The accompanying fixture contains a package.json with [email protected], which depends on ip-address through ^10.2.0. Its npm-generated lock resolves [email protected] and its pnpm-generated lock resolves [email protected]. The files were generated with the respective package managers using historical release cutoffs; neither lock was edited by hand.

With Socket CLI authenticated by the normal supported method, from a fresh copy of the fixture:

npm ci --ignore-scripts --no-audit --no-fund
CI=true pnpm install --frozen-lockfile --ignore-scripts
git init
git add package.json package-lock.json pnpm-lock.yaml .gitignore
git -c user.name=Repro -c [email protected] commit -m baseline

socket fix --all --fix-version 15.12.11 --ecosystems npm \
  --no-major-updates --minimum-release-age 1w --range-style preserve \
  --no-apply-fixes --json --silence . > before.json

socket fix --id GHSA-h3mg-xc3c-68pw,GHSA-j6r3-76f7-8jcv,GHSA-rxp7-6hxx-x8q5 \
  --fix-version 15.12.11 --ecosystems npm --no-major-updates \
  --minimum-release-age 1w --range-style preserve --json --silence . > applied.json

git diff -- package.json package-lock.json pnpm-lock.yaml
socket fix --all --fix-version 15.12.11 --ecosystems npm \
  --no-major-updates --minimum-release-age 1w --range-style preserve \
  --no-apply-fixes --json --silence . > after.json

The targeted apply exits 1, so continue to the diff and rescan even when using a shell configured to exit on errors.

Observed

The initial plan proposes upgrading both locked versions to 10.7.4 for each of the three GHSAs. The apply result is ok: false and reports No file was changed for this upgrade for the 10.5.1 target under all three GHSAs. It also reports the 10.4.0 targets as applied and lists package-lock.json in modifiedFiles.

However, git diff is empty: the npm lock still resolves 10.5.1 and the pnpm lock still resolves 10.4.0. A fresh dry-run still proposes both versions. Thus the reported applied target and modified-file list do not match the actual fixture diff.

For comparison, separate fixtures with the same manifest and only the npm lock or only the pnpm lock both apply the three targeted upgrades successfully, changing the corresponding lock to 10.7.4; the targeted GHSAs are absent from each fresh rescan.

Expected

Each supported lockfile should either be upgraded and reported accurately, or the result should identify the unsupported mixed-lock condition without reporting unchanged files or unresolved targets as applied.

主要语言
TypeScript
星标
335
派生
74
平均合并
1 天 11 小时
30 天内合并 PR
91

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

SocketDev/socket-cli 的其他 Issue

查看 SocketDev/socket-cli 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。