Mixed npm and pnpm locks report an upgrade as applied without changing either lock

Abierto
  • ¿Algo no está bien?
#1,691 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, typescript
Área
cli, security

Línea de trabajo

Start by reproducing with the linked fixture and the exact socket fix commands, then compare the apply result with git diff and a fresh dry-run. Trace how the CLI detects and updates package-lock.json and pnpm-lock.yaml when both are present; the issue names no source files or tests. Done means each lock is either changed and reported accurately, or the mixed-lock condition is reported without claiming unchanged files or unresolved targets were applied.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Mixed npm and pnpm locks report an upgrade as applied without changing either lock

Environment

  • Socket CLI 1.8.2, Coana CLI 15.12.11
  • Node.js 26.13.0, npm 11.20.0, pnpm 10.28.0
  • Linux container; lifecycle scripts disabled
  • Public dependencies only

Reproduction

Public fixture (manifest and both generated lockfiles): https://gist.github.com/ivan-novaprime/ae77a24cb98cc19e9afa0a0f9a108218

The accompanying fixture contains a package.json with [email protected], which depends on ip-address through ^10.2.0. Its npm-generated lock resolves [email protected] and its pnpm-generated lock resolves [email protected]. The files were generated with the respective package managers using historical release cutoffs; neither lock was edited by hand.

With Socket CLI authenticated by the normal supported method, from a fresh copy of the fixture:

npm ci --ignore-scripts --no-audit --no-fund
CI=true pnpm install --frozen-lockfile --ignore-scripts
git init
git add package.json package-lock.json pnpm-lock.yaml .gitignore
git -c user.name=Repro -c [email protected] commit -m baseline

socket fix --all --fix-version 15.12.11 --ecosystems npm \
  --no-major-updates --minimum-release-age 1w --range-style preserve \
  --no-apply-fixes --json --silence . > before.json

socket fix --id GHSA-h3mg-xc3c-68pw,GHSA-j6r3-76f7-8jcv,GHSA-rxp7-6hxx-x8q5 \
  --fix-version 15.12.11 --ecosystems npm --no-major-updates \
  --minimum-release-age 1w --range-style preserve --json --silence . > applied.json

git diff -- package.json package-lock.json pnpm-lock.yaml
socket fix --all --fix-version 15.12.11 --ecosystems npm \
  --no-major-updates --minimum-release-age 1w --range-style preserve \
  --no-apply-fixes --json --silence . > after.json

The targeted apply exits 1, so continue to the diff and rescan even when using a shell configured to exit on errors.

Observed

The initial plan proposes upgrading both locked versions to 10.7.4 for each of the three GHSAs. The apply result is ok: false and reports No file was changed for this upgrade for the 10.5.1 target under all three GHSAs. It also reports the 10.4.0 targets as applied and lists package-lock.json in modifiedFiles.

However, git diff is empty: the npm lock still resolves 10.5.1 and the pnpm lock still resolves 10.4.0. A fresh dry-run still proposes both versions. Thus the reported applied target and modified-file list do not match the actual fixture diff.

For comparison, separate fixtures with the same manifest and only the npm lock or only the pnpm lock both apply the three targeted upgrades successfully, changing the corresponding lock to 10.7.4; the targeted GHSAs are absent from each fresh rescan.

Expected

Each supported lockfile should either be upgraded and reported accurately, or the result should identify the unsupported mixed-lock condition without reporting unchanged files or unresolved targets as applied.

Lenguaje dominante
TypeScript
Estrellas
335
Forks
74
Merge medio
1 d 11 h
PR fusionados (30 d)
91

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de SocketDev/socket-cli

Todos los issues de SocketDev/socket-cli

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.