Request: Fail-closed offline Theme Check API with reliable scan completion reporting
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 20/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
调研方向
Start by tracing the themeCheckRun API in @shopify/theme-check-node and the common runner's check pipeline, then follow graph construction and documentation setup. The issue does not name repository files or tests, so locate the API entry points and existing coverage for error handling and offline documentation. Done means maintainers identify a supported approach or the project adds a way to report completion and failures for every applicable check.
由索引模型根据 Issue 内容生成。
描述
Summary
I'm requesting maintainer guidance on a supported way to run Shopify Theme Check as a fully offline, read-only, fail-closed quality gate using its Node.js API.
Our goal is to verify that all selected checks completed successfully, rather than treating a returned list of offenses as proof that the scan was complete.
We have inspected the installed source and completed isolated configuration and theme-content loading tests. However, we have not established a completed lint scan.
Environment
- Operating system: Windows
- Node.js: 26.12.1
@shopify/theme-check-node: 3.30.1@shopify/theme-check-common: 3.30.1@shopify/theme-check-docs-updater: 3.30.1glob: 8.1.0vscode-uri: 3.2.0- Project: Shopify Online Store 2.0 theme development
- Execution requirements: offline, read-only theme analysis, with narrowly scoped filesystem permissions
What we have verified
- The recommended configuration selects 83 canonical check IDs and 85 built-in check definitions.
- Standalone file discovery identified 156 Liquid/JSON paths.
loadConfig()completed successfully.getTheme()successfully returned 156 SourceCode objects in a bounded diagnostic after an additional theme-specific filesystem read grant was supplied.- No source modifications were observed during that diagnostic.
- A complete Theme Check lint run has not been established or accepted.
On Windows with Node's permission model enabled, we also observed a drive-letter representation mismatch during theme loading. The installed URI formatting path lowercases the Windows drive letter, and the lowercase namespaced filesystem resource was denied under the original read grants. An additional narrow, lowercase-drive read grant allowed content loading in our specific experiment.
We are not assuming that this experimental grant is a general or permanent solution.
Concerns identified in the installed API
1. Check pipeline failures
The common runner appears to ignore rejected check pipelines by default when config.onError is not provided.
The normal themeCheckRun(root, configPath?, log?) API does not appear to expose a supported way to provide that callback.
Question: How can an API consumer reliably detect and fail on every rejected check pipeline?
2. Theme graph failures
The Node wrapper catches graph-construction errors and can continue with degraded cross-file information.
Question: Is there a supported way to require successful graph construction and abort if it fails?
3. Documentation loading failures
The documentation manager may catch setup errors, while loaders can return fallback or empty documentation data.
Question: How can a consumer verify that all required Liquid documentation, schemas, and references loaded correctly without silent degradation?
4. Offline documentation and cache writes
We found that SHOPIFY_TLD_ROOT can select local documentation files.
However, documentation setup may still create cache directories and write files such as latest.json, even when documentation is available locally.
Question: Is there a supported way to use strictly local documentation while redirecting all required cache writes into one explicitly controlled temporary directory?
5. Trustworthy scan completion
The API can return offenses in memory, but we could not establish a supported completion record confirming that every applicable selected check ran successfully.
Question: Is there a supported API or execution mode that distinguishes:
- Check completed successfully with zero offenses
- Check completed with offenses
- Check failed internally
- Check was skipped
- Theme graph failed
- Required documentation failed to initialize
Requested maintainer guidance
Could you recommend an officially supported API or implementation approach that can:
- Run all applicable recommended Liquid, JSON, and whole-theme checks.
- Surface internal check errors rather than silently swallowing them.
- Require successful theme-graph construction.
- Detect missing or incompatible documentation resources.
- Use local documentation with a controlled cache location.
- Return diagnostics and reliable completion status in memory.
- Avoid modifying theme source files or invoking autofix.
- Work offline with network, child-process, and worker permissions denied.
If these guarantees are not available in version 3.30.1, is there a maintainer-recommended version, API, or documented approach that provides them?
A reference implementation or documentation link would be especially helpful.
Additional notes
We are seeking guidance on the supported API contract, not claiming that every observed fallback is necessarily a bug.
We have intentionally excluded private filesystem paths, credentials, commercial source code, and live-store details.
No live Shopify theme or production store was modified.
Thank you for your guidance.
- 主要语言
- TypeScript
- 星标
- 239
- 派生
- 104
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 23
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Shopify/theme-tools 的其他 Issue
-
CdnPreconnect misses `href="https://cdn.shopify.com"` without a trailing path可能已有人在做 @RaphaelFakhri 于 6 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
Shopify/theme-tools#1365 ·
维护者通常 1 天内回复
-
theme-graph CLI never calls getWebComponentMap, so custom-element references are never resolved可能已有人在做 @reginaldalfret 于 24 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 84/100
Shopify/theme-tools#1291 · 1 条评论 ·
维护者通常 1 天内回复
-
JSONMissingBlock false positive for app block when section supports both @app and @theme可能已有人在做 @chippleh1392 于 142 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
Shopify/theme-tools#1144 · 2 条评论 · 8 个 reaction ·
维护者通常 1 天内回复
-
HardcodedRoutes flags paths that only share a prefix with a route可能已有人在做 @RaphaelFakhri 于 8 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 20/100
Shopify/theme-tools#1362 ·
维护者通常 1 天内回复
-
HTML close-tag auto-insertion (`onTypeFormatting` on `>`) closes the wrong element可能已有人在做 @efegokdemir 于 22 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 38/100
Shopify/theme-tools#1327 ·
维护者通常 1 天内回复
查看 Shopify/theme-tools 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
gnosis/gnosis_vpn#661 ·
维护者通常 1 天内回复
-
content-freshness: staleOwnedContent doc comments still say 'complete receipt' (follow-up to #7912)未关闭triage:bug-verified
难度 1/5 1 小时以内 新手友好度 92/100
维护者通常 1 天内回复
-
fix: reject sourceStorage/packagedStorage bucket that differs from the stack default (fail loud)未关闭
难度 2/5 1-3 小时 新手友好度 82/100
Eyevinn/open-videocore#1300 ·
维护者通常 1 天内回复
-
nextjs-tracking
难度 2/5 1-3 小时 新手友好度 67/100
cloudflare/vinext#4390 ·
维护者通常 1 天内回复
-
kind/bug
难度 2/5 1-3 小时 新手友好度 82/100
kubernetes-sigs/headlamp#8175 ·
维护者通常 2 天内回复