Request: Fail-closed offline Theme Check API with reliable scan completion reporting
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 20/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- node.js, typescript
調査の方向性
Start by tracing the themeCheckRun API in @shopify/theme-check-node and the common runner's check pipeline, then follow graph construction and documentation setup. The issue does not name repository files or tests, so locate the API entry points and existing coverage for error handling and offline documentation. Done means maintainers identify a supported approach or the project adds a way to report completion and failures for every applicable check.
索引モデルが issue の本文から書いたものです。
説明
Summary
I'm requesting maintainer guidance on a supported way to run Shopify Theme Check as a fully offline, read-only, fail-closed quality gate using its Node.js API.
Our goal is to verify that all selected checks completed successfully, rather than treating a returned list of offenses as proof that the scan was complete.
We have inspected the installed source and completed isolated configuration and theme-content loading tests. However, we have not established a completed lint scan.
Environment
- Operating system: Windows
- Node.js: 26.12.1
@shopify/theme-check-node: 3.30.1@shopify/theme-check-common: 3.30.1@shopify/theme-check-docs-updater: 3.30.1glob: 8.1.0vscode-uri: 3.2.0- Project: Shopify Online Store 2.0 theme development
- Execution requirements: offline, read-only theme analysis, with narrowly scoped filesystem permissions
What we have verified
- The recommended configuration selects 83 canonical check IDs and 85 built-in check definitions.
- Standalone file discovery identified 156 Liquid/JSON paths.
loadConfig()completed successfully.getTheme()successfully returned 156 SourceCode objects in a bounded diagnostic after an additional theme-specific filesystem read grant was supplied.- No source modifications were observed during that diagnostic.
- A complete Theme Check lint run has not been established or accepted.
On Windows with Node's permission model enabled, we also observed a drive-letter representation mismatch during theme loading. The installed URI formatting path lowercases the Windows drive letter, and the lowercase namespaced filesystem resource was denied under the original read grants. An additional narrow, lowercase-drive read grant allowed content loading in our specific experiment.
We are not assuming that this experimental grant is a general or permanent solution.
Concerns identified in the installed API
1. Check pipeline failures
The common runner appears to ignore rejected check pipelines by default when config.onError is not provided.
The normal themeCheckRun(root, configPath?, log?) API does not appear to expose a supported way to provide that callback.
Question: How can an API consumer reliably detect and fail on every rejected check pipeline?
2. Theme graph failures
The Node wrapper catches graph-construction errors and can continue with degraded cross-file information.
Question: Is there a supported way to require successful graph construction and abort if it fails?
3. Documentation loading failures
The documentation manager may catch setup errors, while loaders can return fallback or empty documentation data.
Question: How can a consumer verify that all required Liquid documentation, schemas, and references loaded correctly without silent degradation?
4. Offline documentation and cache writes
We found that SHOPIFY_TLD_ROOT can select local documentation files.
However, documentation setup may still create cache directories and write files such as latest.json, even when documentation is available locally.
Question: Is there a supported way to use strictly local documentation while redirecting all required cache writes into one explicitly controlled temporary directory?
5. Trustworthy scan completion
The API can return offenses in memory, but we could not establish a supported completion record confirming that every applicable selected check ran successfully.
Question: Is there a supported API or execution mode that distinguishes:
- Check completed successfully with zero offenses
- Check completed with offenses
- Check failed internally
- Check was skipped
- Theme graph failed
- Required documentation failed to initialize
Requested maintainer guidance
Could you recommend an officially supported API or implementation approach that can:
- Run all applicable recommended Liquid, JSON, and whole-theme checks.
- Surface internal check errors rather than silently swallowing them.
- Require successful theme-graph construction.
- Detect missing or incompatible documentation resources.
- Use local documentation with a controlled cache location.
- Return diagnostics and reliable completion status in memory.
- Avoid modifying theme source files or invoking autofix.
- Work offline with network, child-process, and worker permissions denied.
If these guarantees are not available in version 3.30.1, is there a maintainer-recommended version, API, or documented approach that provides them?
A reference implementation or documentation link would be especially helpful.
Additional notes
We are seeking guidance on the supported API contract, not claiming that every observed fallback is necessarily a bug.
We have intentionally excluded private filesystem paths, credentials, commercial source code, and live-store details.
No live Shopify theme or production store was modified.
Thank you for your guidance.
- 主要言語
- TypeScript
- スター
- 239
- フォーク
- 104
- 平均マージ
- 1日 2時間
- マージ済み PR(30日)
- 23
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
Shopify/theme-tools のほかの issue
-
CdnPreconnect misses `href="https://cdn.shopify.com"` without a trailing path対応中かも @RaphaelFakhri が 6 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Shopify/theme-tools#1365 ·
メンテナーはふだん 1 日以内に返信
-
theme-graph CLI never calls getWebComponentMap, so custom-element references are never resolved対応中かも @reginaldalfret が 24 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
Shopify/theme-tools#1291 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
JSONMissingBlock false positive for app block when section supports both @app and @theme対応中かも @chippleh1392 が 141 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
Shopify/theme-tools#1144 · コメント 2 件 · リアクション 8 件 ·
メンテナーはふだん 1 日以内に返信
-
HardcodedRoutes flags paths that only share a prefix with a route対応中かも @RaphaelFakhri が 7 日前に担当しました。 オープン
難易度 3/5 1〜2日 初心者へのやさしさ 20/100
Shopify/theme-tools#1362 ·
メンテナーはふだん 1 日以内に返信
-
HTML close-tag auto-insertion (`onTypeFormatting` on `>`) closes the wrong element対応中かも @efegokdemir が 22 日前に担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 38/100
Shopify/theme-tools#1327 ·
メンテナーはふだん 1 日以内に返信
Shopify/theme-tools の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
vekexasia/pi-extensible-workflows#374 ·
メンテナーはふだん 2 日以内に返信
-
documentation good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 77/100
メンテナーはふだん 1 日以内に返信
-
help wanted linux
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
GiuseppeBellamacina/downtime#19 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
scaleway/ultraviolet#7089 ·
メンテナーはふだん 2 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
Get-Concord-AI/concord-mcp#296 ·
メンテナーはふだん 1 日以内に返信