angular-bundle: budgets/webpack validators call methods that do not exist; the TypeError is swallowed and 'missing' is always reported

未关闭
#423 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
领域
testing, tooling

调研方向

Start with src/utils/angular/angular-bundle/angular-bundle-validation-patterns.ts, src/laws/performance/performance-budget-compliance.ts, and src/utils/angular/angular-bundle/angular-bundle-optimization-analyzer.ts to trace the validators and their callers. Add a regression test using an angular.json with configured production budgets, then run the relevant tests. Done means configured budgets no longer produce the “missing” suggestion and failures to read configuration are reported explicitly.

由索引模型根据 Issue 内容生成。

描述

bug

Version: 7.29.1 (npm latest, 5fc54afe). Same code on develop (2d2fa9a).
Area: src/utils/angular/angular-bundle/angular-bundle-validation-patterns.ts (used by the Lazy Loading Implementation checker through AngularBundleOptimizationAnalyzer.checkBundleOptimization)

What happens

validatePerformanceBudgets and validateWebpackConfiguration cast PerformanceBudgetComplianceLaw with as unknown as { … } and call two methods it does not have:

// angular-bundle-validation-patterns.ts:94-99 (and :123-129 for the webpack one)
const law = PerformanceBudgetComplianceLaw as unknown as {
  checkAngularPerformanceBudgets: (projectRoot: string) => { configured: boolean };
};
const budgetAnalysis = law.checkAngularPerformanceBudgets(projectRoot);   // undefined is not a function
...
} catch {
  suggestions.push(PERFORMANCE_BUDGETS_MISSING().suggestionMessage);      // the TypeError lands here
}

PerformanceBudgetComplianceLaw only has static async check(context) (src/laws/performance/performance-budget-compliance.ts:30). Every call therefore throws a TypeError. The catch swallows it and adds the "missing" suggestion, whatever the project actually configures. The double cast is what keeps the compiler from reporting it.

Reproduction (published 7.29.1 dist)

A temp directory whose angular.json has a production budgets entry (initial, 500kb / 1mb), called directly against dist/utils/angular/angular-bundle/angular-bundle-validation-patterns.js:

PerformanceBudgetComplianceLaw own static members: [ 'check' ]
typeof checkAngularPerformanceBudgets: undefined | typeof checkWebpackPerformanceConfig: undefined
budgets configured in angular.json -> validatePerformanceBudgets suggestions: ["Add performance budgets in angular.json build configuration"]
validateWebpackConfiguration suggestions: ["Configure webpack performance settings and optimization"]

What I ruled out

  • This is not a test-only path: the Lazy Loading Implementation checker calls AngularBundleOptimizationAnalyzer.checkBundleOptimization, which calls both validators (angular-bundle-optimization-analyzer.ts:47,51).
  • I did not measure whether the suggestion changes the law's pass/fail verdict or only its suggestions text. I only proved that the output is independent of the project.

Why it matters

The output claims budgets are missing in a project that configures them, and the catch hides the reason. This is the opposite of the tool's own rule of saying when it could not judge something. It was found in the 8.0.0 self-audit triage: the No Double Cast law flags these two casts, and they are real debt, not a detector error.

Suggested direction

  1. Call real code: either expose a budget/webpack reader (for example in src/utils/angular/) that both this analyzer and PerformanceBudgetComplianceLaw use, or read angular.json budgets directly here.
  2. Drop the as unknown as casts and the bare catch. An unreadable angular.json should become an explicit "not read" note, not a "missing" suggestion.
  3. Add a regression test with a configured budget that expects no "missing" suggestion. Today it would fail.
主要语言
TypeScript
星标
0
派生
0
平均合并
38 分钟
30 天内合并 PR
96

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Rule-Of-Code/RoC 的其他 Issue

查看 Rule-Of-Code/RoC 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。