angular-bundle: budgets/webpack validators call methods that do not exist; the TypeError is swallowed and 'missing' is always reported
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- angular, node.js, typescript
Direzione di ricerca
Start with src/utils/angular/angular-bundle/angular-bundle-validation-patterns.ts, src/laws/performance/performance-budget-compliance.ts, and src/utils/angular/angular-bundle/angular-bundle-optimization-analyzer.ts to trace the validators and their callers. Add a regression test using an angular.json with configured production budgets, then run the relevant tests. Done means configured budgets no longer produce the “missing” suggestion and failures to read configuration are reported explicitly.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Version: 7.29.1 (npm latest, 5fc54afe). Same code on develop (2d2fa9a).
Area: src/utils/angular/angular-bundle/angular-bundle-validation-patterns.ts (used by the Lazy Loading Implementation checker through AngularBundleOptimizationAnalyzer.checkBundleOptimization)
What happens
validatePerformanceBudgets and validateWebpackConfiguration cast PerformanceBudgetComplianceLaw with as unknown as { … } and call two methods it does not have:
// angular-bundle-validation-patterns.ts:94-99 (and :123-129 for the webpack one)
const law = PerformanceBudgetComplianceLaw as unknown as {
checkAngularPerformanceBudgets: (projectRoot: string) => { configured: boolean };
};
const budgetAnalysis = law.checkAngularPerformanceBudgets(projectRoot); // undefined is not a function
...
} catch {
suggestions.push(PERFORMANCE_BUDGETS_MISSING().suggestionMessage); // the TypeError lands here
}
PerformanceBudgetComplianceLaw only has static async check(context) (src/laws/performance/performance-budget-compliance.ts:30). Every call therefore throws a TypeError. The catch swallows it and adds the "missing" suggestion, whatever the project actually configures. The double cast is what keeps the compiler from reporting it.
Reproduction (published 7.29.1 dist)
A temp directory whose angular.json has a production budgets entry (initial, 500kb / 1mb), called directly against dist/utils/angular/angular-bundle/angular-bundle-validation-patterns.js:
PerformanceBudgetComplianceLaw own static members: [ 'check' ]
typeof checkAngularPerformanceBudgets: undefined | typeof checkWebpackPerformanceConfig: undefined
budgets configured in angular.json -> validatePerformanceBudgets suggestions: ["Add performance budgets in angular.json build configuration"]
validateWebpackConfiguration suggestions: ["Configure webpack performance settings and optimization"]
What I ruled out
- This is not a test-only path: the Lazy Loading Implementation checker calls
AngularBundleOptimizationAnalyzer.checkBundleOptimization, which calls both validators (angular-bundle-optimization-analyzer.ts:47,51). - I did not measure whether the suggestion changes the law's pass/fail verdict or only its suggestions text. I only proved that the output is independent of the project.
Why it matters
The output claims budgets are missing in a project that configures them, and the catch hides the reason. This is the opposite of the tool's own rule of saying when it could not judge something. It was found in the 8.0.0 self-audit triage: the No Double Cast law flags these two casts, and they are real debt, not a detector error.
Suggested direction
- Call real code: either expose a budget/webpack reader (for example in
src/utils/angular/) that both this analyzer andPerformanceBudgetComplianceLawuse, or readangular.jsonbudgets directly here. - Drop the
as unknown ascasts and the barecatch. An unreadableangular.jsonshould become an explicit "not read" note, not a "missing" suggestion. - Add a regression test with a configured budget that expects no "missing" suggestion. Today it would fail.
- Lingua principale
- TypeScript
- Stelle
- 0
- Fork
- 0
- Merge medio
- 38m
- PR unite (30g)
- 96
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Rule-Of-Code/RoC
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
Rule-Of-Code/RoC#436 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
Rule-Of-Code/RoC#439 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 49/100
Rule-Of-Code/RoC#438 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 53/100
Rule-Of-Code/RoC#437 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 74/100
Rule-Of-Code/RoC#435 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di Rule-Of-Code/RoC
Issue simili
-
documentation lens:human needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
thebristolsound/birdbrain#2246 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
A voting window past about 69.9 million hours stores a deadline that reads back as no deadlineApertabug ready-for-human
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
BoardGamesEmpire/board-games-empire-backend#1452 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
good first issue stretch
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno