perf(catalog): ERD neighbourhood and MCP describe/sample read the whole schema catalog; filter tables in SQL
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 42/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- dart, mysql, postgresql, sqlite
- 领域
- databases, performance
调研方向
Start with lib/core/erd/erd_catalog.dart:198-248 and lib/core/mcp/mcp_query_service.dart:245-270, then inspect the columnsSql and viewColumnsSql definitions for PostgreSQL, MySQL, and SQLite. Trace how ERD neighbourhood names and MCP table validation flow into those queries, and review the related tests. Done means SQL filters catalog reads to the requested tables, MCP uses a cheap existence check where appropriate, and a neighbourhood remains complete beyond the catalog row limit.
由索引模型根据 Issue 内容生成。
描述
Problem
Two paths read the whole schema catalog when they need a few tables:
- ERD neighbourhood (
ErdCatalog.loadNeighbourhood,lib/core/erd/erd_catalog.dart:198-248). It loads all FKs (needed for the graph walk), then for every schema in the neighbourhood runscolumnsSqlfor all columns of that schema and filters in Dart (if (names.contains(r[0])),:230/:238). The PostgreSQLcolumnsSqlhas per-column correlated subqueries (unique-indexEXISTS,pg_enumstring_agg,col_description,pg_get_expr), so the cost grows with the schema, not with the diagram. WithcatalogRowLimit = 200000(:19) a large schema is truncated before filtering, so the focused table can lose its columns even though it needs only a few rows. - MCP
describe_table/sample_rows(McpQueryService._loadCatalog,lib/core/mcp/mcp_query_service.dart:245-270). To find one table it runs three catalog queries over the whole schema (columns, FKs, view columns) on every call.sample_rowsuses the result only to validate the table name.
Fix
- Add a table filter to
columnsSql/viewColumnsSql: PostgreSQLc.relname = ANY($names)per schema, MySQLtable_name IN (...), SQLitem.name IN (...)(literal-escaped as in_lit, or bind parameters where the delegate supports them). - ERD neighbourhood: walk FKs first, then fetch columns only for the resulting names.
- MCP: validate the name with a cheap existence query (
to_regclass/information_schema.tables/sqlite_master), and describe one table with the filtered column/FK queries. Keep the full catalog only forlist_tablesand theschema://resource. - Tests: the generated SQL contains the filter; the neighbourhood of a table in a schema larger than the row limit is complete.
Related: ERD epic #1166 and #1167 (same catalog SQL).
- 主要语言
- Dart
- 星标
- 23
- 派生
- 1
- 平均合并
- 31 分钟
- 30 天内合并 PR
- 570
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
QueryaHub/Querya-Desktop 的其他 Issue
-
enhancement ui
难度 2/5 1-3 小时 新手友好度 78/100
QueryaHub/Querya-Desktop#1689 ·
维护者通常 1 天内回复
-
ui(dialogs): make destructive query and DML preview dialogs adaptive and prevent table name overflow未关闭bug frontend
难度 2/5 1-3 小时 新手友好度 82/100
QueryaHub/Querya-Desktop#1642 ·
维护者通常 1 天内回复
-
bug error-handling settings
难度 1/5 1-3 小时 新手友好度 78/100
QueryaHub/Querya-Desktop#1637 ·
维护者通常 1 天内回复
-
enhancement
难度 1/5 1 小时以内 新手友好度 88/100
QueryaHub/Querya-Desktop#1636 ·
维护者通常 1 天内回复
-
enhancement marketplace
难度 2/5 1-3 小时 新手友好度 78/100
QueryaHub/Querya-Desktop#1635 ·
维护者通常 1 天内回复
查看 QueryaHub/Querya-Desktop 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
AppFlowy-IO/AppFlowy#9075 ·
-
Paste asks for iOS paste permission because the default context menu ignores SystemContextMenu可能已有人在做 @dorklein 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
maheshj01/searchfield#267 ·
-
难度 2/5 1-3 小时 新手友好度 67/100
-
难度 2/5 1-3 小时 新手友好度 72/100
avdept/JellyBoxPlayer#375 ·
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 82/100
basictech01/uniun#300 ·
维护者通常 1 天内回复