perf(catalog): ERD neighbourhood and MCP describe/sample read the whole schema catalog; filter tables in SQL
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 42/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- dart, mysql, postgresql, sqlite
- 領域
- databases, performance
研究方向
Start with lib/core/erd/erd_catalog.dart:198-248 and lib/core/mcp/mcp_query_service.dart:245-270, then inspect the columnsSql and viewColumnsSql definitions for PostgreSQL, MySQL, and SQLite. Trace how ERD neighbourhood names and MCP table validation flow into those queries, and review the related tests. Done means SQL filters catalog reads to the requested tables, MCP uses a cheap existence check where appropriate, and a neighbourhood remains complete beyond the catalog row limit.
由索引模型根據 Issue 內容生成。
描述
Problem
Two paths read the whole schema catalog when they need a few tables:
- ERD neighbourhood (
ErdCatalog.loadNeighbourhood,lib/core/erd/erd_catalog.dart:198-248). It loads all FKs (needed for the graph walk), then for every schema in the neighbourhood runscolumnsSqlfor all columns of that schema and filters in Dart (if (names.contains(r[0])),:230/:238). The PostgreSQLcolumnsSqlhas per-column correlated subqueries (unique-indexEXISTS,pg_enumstring_agg,col_description,pg_get_expr), so the cost grows with the schema, not with the diagram. WithcatalogRowLimit = 200000(:19) a large schema is truncated before filtering, so the focused table can lose its columns even though it needs only a few rows. - MCP
describe_table/sample_rows(McpQueryService._loadCatalog,lib/core/mcp/mcp_query_service.dart:245-270). To find one table it runs three catalog queries over the whole schema (columns, FKs, view columns) on every call.sample_rowsuses the result only to validate the table name.
Fix
- Add a table filter to
columnsSql/viewColumnsSql: PostgreSQLc.relname = ANY($names)per schema, MySQLtable_name IN (...), SQLitem.name IN (...)(literal-escaped as in_lit, or bind parameters where the delegate supports them). - ERD neighbourhood: walk FKs first, then fetch columns only for the resulting names.
- MCP: validate the name with a cheap existence query (
to_regclass/information_schema.tables/sqlite_master), and describe one table with the filtered column/FK queries. Keep the full catalog only forlist_tablesand theschema://resource. - Tests: the generated SQL contains the filter; the neighbourhood of a table in a schema larger than the row limit is complete.
Related: ERD epic #1166 and #1167 (same catalog SQL).
- 主要語言
- Dart
- 星號
- 23
- 分支
- 1
- 平均合併
- 31 分鐘
- 30 天內合併 PR
- 570
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
QueryaHub/Querya-Desktop 的其他 Issue
-
enhancement ui
難度 2/5 1-3 小時 新手友好度 78/100
QueryaHub/Querya-Desktop#1689 ·
維護者通常 1 天內回覆
-
ui(dialogs): make destructive query and DML preview dialogs adaptive and prevent table name overflow未關閉bug frontend
難度 2/5 1-3 小時 新手友好度 82/100
QueryaHub/Querya-Desktop#1642 ·
維護者通常 1 天內回覆
-
bug error-handling settings
難度 1/5 1-3 小時 新手友好度 78/100
QueryaHub/Querya-Desktop#1637 ·
維護者通常 1 天內回覆
-
enhancement
難度 1/5 1 小時以內 新手友好度 88/100
QueryaHub/Querya-Desktop#1636 ·
維護者通常 1 天內回覆
-
enhancement marketplace
難度 2/5 1-3 小時 新手友好度 78/100
QueryaHub/Querya-Desktop#1635 ·
維護者通常 1 天內回覆
查看 QueryaHub/Querya-Desktop 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
good-first-issue P3
難度 2/5 1-3 小時 新手友好度 88/100
flutter/dart-intellij-third-party#758 ·
維護者通常 1 天內回覆
-
Bug: Incorrect location coordinates on logged Sound Meter data可能已有人在做 @Jashan32 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
area/archive bug
難度 2/5 1-3 小時 新手友好度 76/100
DarkFlippers/qUnleashed#374 ·
維護者通常 1 天內回覆
-
agent:in-progress agent:ready feature P2 · 中 区域: 悬浮窗
難度 2/5 1-3 小時 新手友好度 85/100
ASDW51/DanmuFloat#178 ·
維護者通常 1 天內回覆