Improvements to Kirchhoff operator
维护者通常 2 天内回复
@dikwickley 已经在做这个了。
开始于 2023年1月25日。
评估
调研方向
Start by reading the discussions in PRs #431 and #418, then inspect pylops.waveeqprocessing.Kirchhoff and _wavelet_reshaping. The issue leaves key definitions unresolved, including the 2.5D wavelet parameters and aperture for heterogeneous velocities. Done means resolving the remaining design questions and implementing the unchecked features, including dynamic features in 3D.
由索引模型根据 Issue 内容生成。
描述
Motivation
The pylops.waveeqprocessing.Kirchhoff operator has gone through a major restyling in https://github.com/PyLops/pylops/pull/431 mostly aimed at including dynamic capabilities. From the discussions in the https://github.com/PyLops/pylops/pull/431 and https://github.com/PyLops/pylops/pull/418 we have identified the following areas that may need further improvement. Moreover some of the new features in such PR are so far only available for the 2D implementation.
Features to be implemented
- Add 2.5D wavelet filtering in
_wavelet_reshaping. Current roadblock is represented by the unclear definition of σ_S and σ_R in equation 2.3.7 of Safron2018 (neither in the Bleistein and Gray, 2002 paper). - Devise a new definition of
aperturenot simply based on the offset/depth ratio to be used for heterogeneous velocity models. Currently we raise a warning when a user decides to activate such aperture limitation -
Finalize discussion about the role ofsnell, and if this is actually needed at all. - Finalize discussion about angle scaling and introduce
cospoweras discussed in the PR -
Implement angle scaling with normal (instead of vertical) when anglerefl is provided - Implement all features when
dynamic=Truein 3D
- 主要语言
- Python
- 星标
- 539
- 派生
- 126
- 平均合并
- 2 天 17 小时
- 30 天内合并 PR
- 21
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
PyLops/pylops 的其他 Issue
-
Lipschitz method可能已有人在做 @Megumi1773 于 26 天前认领。 未关闭enhancement good first issue
难度 4/5 3-5 天 新手友好度 25/100
维护者通常 2 天内回复
-
enhancement
难度 4/5 3-5 天 新手友好度 45/100
维护者通常 2 天内回复
-
CI
难度 3/5 1-2 天 新手友好度 52/100
维护者通常 2 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 25/100
维护者通常 2 天内回复
-
难度 3/5 1-2 天 新手友好度 38/100
PyLops/pylops#731 · 4 条评论 · 1 个 reaction ·
维护者通常 2 天内回复
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 78/100
QuantConnect/Documentation#2838 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
awslabs/route53-dynamic-dns-with-lambda#67 · 1 条评论 ·
-
`SubAgents` returns a child run's `DeferredToolRequests` to the parent as a successful tool result未关闭bug pkg:harness
难度 2/5 1-3 小时 新手友好度 70/100
pydantic/pydantic-ai#12405 ·
维护者通常 1 天内回复
-
good first issue help wanted
难度 2/5 1-3 小时 新手友好度 78/100
-
good first issue help wanted
难度 1/5 1 小时以内 新手友好度 82/100