Improvements to Kirchhoff operator

Abierto
  • ¿Algo no está bien?
#439 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@dikwickley ya está trabajando en esto.

Desde el 25/1/2023.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
15/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
python
Área
backend

Línea de trabajo

Start by reading the discussions in PRs #431 and #418, then inspect pylops.waveeqprocessing.Kirchhoff and _wavelet_reshaping. The issue leaves key definitions unresolved, including the 2.5D wavelet parameters and aperture for heterogeneous velocities. Done means resolving the remaining design questions and implementing the unchecked features, including dynamic features in 3D.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement good first issue help wanted

Motivation

The pylops.waveeqprocessing.Kirchhoff operator has gone through a major restyling in https://github.com/PyLops/pylops/pull/431 mostly aimed at including dynamic capabilities. From the discussions in the https://github.com/PyLops/pylops/pull/431 and https://github.com/PyLops/pylops/pull/418 we have identified the following areas that may need further improvement. Moreover some of the new features in such PR are so far only available for the 2D implementation.

Features to be implemented

  • Add 2.5D wavelet filtering in _wavelet_reshaping. Current roadblock is represented by the unclear definition of σ_S and σ_R in equation 2.3.7 of Safron2018 (neither in the Bleistein and Gray, 2002 paper).
  • Devise a new definition of aperture not simply based on the offset/depth ratio to be used for heterogeneous velocity models. Currently we raise a warning when a user decides to activate such aperture limitation
  • Finalize discussion about the role of snell, and if this is actually needed at all.
  • Finalize discussion about angle scaling and introduce cospower as discussed in the PR
  • Implement angle scaling with normal (instead of vertical) when anglerefl is provided
  • Implement all features when dynamic=True in 3D
Lenguaje dominante
Python
Estrellas
539
Forks
126
Merge medio
2 d 17 h
PR fusionados (30 d)
21

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PyLops/pylops

Todos los issues de PyLops/pylops

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.