Code signing certificate expired on version 1.25.0

未关闭
#2,302 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
1-2 天
新手友好度
18/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
领域
release

调研方向

The problem is in the signed package, not in source code: open the .signature.p7s file inside the 1.25.0 nupkg and check the certificate chain, and compare it with the signed PSScriptAnalyzer.psm1. Fixing it requires the project's signing credentials and a release decision from maintainers, so a newcomer can only confirm the expiry and discuss an RFC 3161 timestamp approach. Done means a re-signed or timestamped release that passes the chain check.

由索引模型根据 Issue 内容生成。

描述

  • The code signing certificate used to sign PSScriptAnalyzer version 1.25.0 has expired and the PSScriptAnalyzer.psm1 does not contain a RFC 3161 timestamp (which could be used to confirm the file was created before the certificate expiration). This makes it difficult to "clean-source" PSScriptAnalyzer before integrating it

Steps to reproduce

  1. Open the ".signature.p7s" file contained in the nupkg package
  2. In "certmgr", browse to the "Microsoft Corporation" code signing certificate and open it
  3. You will see the certificate has expired.

Expected behavior

The code signing chain is intact and valid

Actual behavior

image

If an unexpected error was thrown then please report the full error details using e.g. $error[0] | Select-Object *

Environment data

> $PSVersionTable
Name                           Value                                                                                                     
----                           -----                                                                                                     
PSVersion                      5.1.26100.9444                                                                                            
PSEdition                      Desktop                                                                                                   
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                   
BuildVersion                   10.0.26100.9444                                                                                           
CLRVersion                     4.0.30319.42000                                                                                           
WSManStackVersion              3.0                                                                                                       
PSRemotingProtocolVersion      2.3                                                                                                       
SerializationVersion           1.1.0.1  


> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
PSScriptAnalyzer).Version: 1.24.0
主要语言
C#
星标
2.2k
派生
422
平均合并
2 小时 23 分钟
30 天内合并 PR
25

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PowerShell/PSScriptAnalyzer 的其他 Issue

查看 PowerShell/PSScriptAnalyzer 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。