Code signing certificate expired on version 1.25.0

未關閉
#2,302 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
1-2 天
新手友好度
18/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
領域
release

研究方向

The problem is in the signed package, not in source code: open the .signature.p7s file inside the 1.25.0 nupkg and check the certificate chain, and compare it with the signed PSScriptAnalyzer.psm1. Fixing it requires the project's signing credentials and a release decision from maintainers, so a newcomer can only confirm the expiry and discuss an RFC 3161 timestamp approach. Done means a re-signed or timestamped release that passes the chain check.

由索引模型根據 Issue 內容生成。

描述

  • The code signing certificate used to sign PSScriptAnalyzer version 1.25.0 has expired and the PSScriptAnalyzer.psm1 does not contain a RFC 3161 timestamp (which could be used to confirm the file was created before the certificate expiration). This makes it difficult to "clean-source" PSScriptAnalyzer before integrating it

Steps to reproduce

  1. Open the ".signature.p7s" file contained in the nupkg package
  2. In "certmgr", browse to the "Microsoft Corporation" code signing certificate and open it
  3. You will see the certificate has expired.

Expected behavior

The code signing chain is intact and valid

Actual behavior

image

If an unexpected error was thrown then please report the full error details using e.g. $error[0] | Select-Object *

Environment data

> $PSVersionTable
Name                           Value                                                                                                     
----                           -----                                                                                                     
PSVersion                      5.1.26100.9444                                                                                            
PSEdition                      Desktop                                                                                                   
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                   
BuildVersion                   10.0.26100.9444                                                                                           
CLRVersion                     4.0.30319.42000                                                                                           
WSManStackVersion              3.0                                                                                                       
PSRemotingProtocolVersion      2.3                                                                                                       
SerializationVersion           1.1.0.1  


> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
PSScriptAnalyzer).Version: 1.24.0
主要語言
C#
星號
2.2k
分支
422
平均合併
2 小時 23 分鐘
30 天內合併 PR
25

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

PowerShell/PSScriptAnalyzer 的其他 Issue

查看 PowerShell/PSScriptAnalyzer 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。